From: marex@denx•de (Marek Vasut)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 12/12] USB: chipidea: add imx usbmisc support
Date: Mon, 16 Jul 2012 14:24:24 +0200 [thread overview]
Message-ID: <201207161424.24873.marex@denx.de> (raw)
In-Reply-To: <1342076512-19207-13-git-send-email-richard.zhao@freescale.com>
Dear Richard Zhao,
[...]
> +static int imx6q_usbmisc_init(struct usbmisc *usbmisc, int id)
> +{
> + u32 reg;
> +
> + if (usbmisc->dis_oc) {
> + reg = readl_relaxed(usbmisc->base + id * 4);
> + writel_relaxed(reg | (1 << 7), usbmisc->base + id * 4);
1<< 7 ? This yearns for fixing with proper #defined value.
[...]
The rest of the patches looks OK, you can add my Reviewed-By: <marex@denx•de> to
those. This one though will need further investigation.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-07-16 12:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 7:01 [PATCH 00/12] chipidea/imx: add otg support and some bug fix Richard Zhao
2012-07-12 7:01 ` [PATCH 01/12] USB: chipidea: imx: add pinctrl support Richard Zhao
2012-07-12 7:01 ` [PATCH 02/12] USB: chipidea: delay 2ms before read ID status at probe time Richard Zhao
2012-07-12 7:01 ` [PATCH 03/12] USB: chipidea: move OTGSC_IDIS clearing from ci_role_work to irq handler Richard Zhao
2012-07-12 7:01 ` [PATCH 04/12] USB: chipidea: clear gadget struct at udc_start fail path Richard Zhao
2012-07-12 7:01 ` [PATCH 05/12] USB: chipidea: don't let probe fail if otg controller start one role failed Richard Zhao
2012-07-12 7:01 ` [PATCH 06/12] USB: mxs-phy: add basic otg support Richard Zhao
2012-07-12 7:01 ` [PATCH 07/12] USB: chipidea: add vbus detect for udc Richard Zhao
2012-07-12 7:01 ` [PATCH 08/12] USB: chipidea: convert to use devm_request_irq Richard Zhao
2012-07-12 7:01 ` [PATCH 09/12] USB: chipidea: add -DDEBUG if CONFIG_USB_CHIPIDEA_DEBUG Richard Zhao
2012-07-12 7:01 ` [PATCH 10/12] USB: chipidea: add set_vbus_power support Richard Zhao
2012-07-16 12:10 ` Marc Kleine-Budde
2012-07-17 1:30 ` Richard Zhao
2012-07-12 7:01 ` [PATCH 11/12] USB: chipidea: re-order irq handling to avoid unhandled irq Richard Zhao
2012-07-12 7:01 ` [PATCH 12/12] USB: chipidea: add imx usbmisc support Richard Zhao
2012-07-12 7:10 ` Richard Zhao
2012-07-13 12:25 ` Michael Grzeschik
2012-07-13 14:02 ` Richard Zhao
2012-07-13 14:14 ` Marc Kleine-Budde
2012-07-16 2:53 ` Richard Zhao
2012-07-16 8:25 ` Sascha Hauer
2012-07-16 8:38 ` Richard Zhao
2012-07-16 8:50 ` Sascha Hauer
2012-07-16 12:24 ` Marek Vasut [this message]
2012-07-17 0:40 ` [PATCH 00/12] chipidea/imx: add otg support and some bug fix Greg KH
2012-07-19 2:05 ` Richard Zhao
2012-07-26 10:59 ` Richard Zhao
2012-07-30 9:17 ` Richard Zhao
2012-07-30 16:00 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207161424.24873.marex@denx.de \
--to=marex@denx$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox