From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 00/25] make *struct of_device_id.data const
Date: Tue, 24 Jul 2012 15:01:47 +0000 [thread overview]
Message-ID: <201207241501.48302.arnd@arndb.de> (raw)
In-Reply-To: <1343034810-3386-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Monday 23 July 2012, Uwe Kleine-K?nig wrote:
> this is the 2nd version of this series whose goal is to make struct
> of_device_id.data const. Conceptually a driver must not modify the data
> contained there so making it const is the right thing.
>
> v1 of this series was sent with Message-id:
> 1342182734-321-1-git-send-email-y. Changes since then are:
> - powerpc fixes
> - several new consts that were found by Arnd that are possible after
> patch 19.
>
> Arnd suggested to take this series via arm-soc late for 3.6 in one go
> because patch 19 depends on the former patches but is a precondition to
> the latter and it fixes a few warnings. So getting it in via the
> respective maintainer trees would need a much bigger coordination
> effort. That means I prefer getting Acks over you taking the patch.
>
> Vinod Koul already took
> dmaengine: at_hdmac: add a few const qualifiers
> that is in next-20120723 as 7fd63ccdad72 now. Vinod, I don't follow your
> pull requests, but assuming you didn't let it already pull for 3.6 I
> suggest you drop it from your queue and I just take your Ack.
>
> This series was build tested for arm (all defconfigs) and powerpc (all
> defconfigs and an allyesconfig) and grep didn't find more issues. As
> before it introduces a warning in drivers/regulator/twl-regulator.c.
> This driver does modify its .of_match_table when a device is bound which
> doesn't fits the concept of independant devices. Arnd noticed another
> new warning in drivers/scsi/qlogicpti.c that isn't that easy to resolve,
> because the pointer to (now) const data is passed as first argument to
> scsi_host_alloc. To fix that properly struct Scsi_Host.hostt needs to
> get a const, too. Alternatively I could introduce a cast removing the
> const, but I don't like that.
>
> This series is also available at:
>
> git://git.pengutronix.de/git/ukl/linux.git ofdeviceiddata
>
> and I will modify it there for the Acks I'm getting.
Pulled the entire series into arm-soc/late/warnings. Thanks everyone
who provided Acks. I'll wait for a few more days to let this sit
in linux-next and if nobody complains, Olof or I will forward it
to Linus.
Arnd
next prev parent reply other threads:[~2012-07-24 15:01 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 9:13 [PATCH v2 00/25] make *struct of_device_id.data const Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 01/25] spi/imx: make spi_imx_data.devtype_data member point to const data Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 02/25] spi/spi-omap2-mcspi: add a const qualifier Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 03/25] serial/imx: make imx_port.devdata member point to const data Uwe Kleine-König
2012-07-23 15:31 ` Greg Kroah-Hartman
2012-07-23 9:13 ` [PATCH 04/25] serial/mpc52xx_uart: add a const qualifier Uwe Kleine-König
2012-07-23 15:31 ` Greg Kroah-Hartman
2012-07-23 9:13 ` [PATCH 05/25] ARM: cache-l2x0: " Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 06/25] misc/atmel_tc: make atmel_tc.tcb_config member point to const data Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 07/25] gpio/gpio-omap.c: add a const qualifier Uwe Kleine-König
2012-07-29 16:13 ` Linus Walleij
2012-07-30 8:18 ` Santosh Shilimkar
2012-07-23 9:13 ` [PATCH 08/25] gpio/mpc8xxx: " Uwe Kleine-König
2012-07-29 16:13 ` Linus Walleij
2012-07-23 9:13 ` [PATCH 09/25] i2c/i2c-omap: " Uwe Kleine-König
2012-07-23 17:27 ` Datta, Shubhrajyoti
2012-07-23 9:13 ` [PATCH 10/25] i2c/mpc: " Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 11/25] dmaengine: at_hdmac: add a few const qualifiers Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 12/25] mmc/omap_hsmmc: add a const qualifier Uwe Kleine-König
2012-07-23 15:41 ` S, Venkatraman
2012-07-23 9:13 ` [PATCH 13/25] macintosh/mediabay: " Uwe Kleine-König
2012-09-05 2:40 ` Benjamin Herrenschmidt
2012-09-05 8:02 ` Uwe Kleine-König
2012-09-05 9:23 ` Benjamin Herrenschmidt
2012-09-11 6:56 ` Uwe Kleine-König
2012-09-11 7:08 ` Benjamin Herrenschmidt
2012-07-23 9:13 ` [PATCH 14/25] powerpc/83xx: " Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 15/25] powerpc/fsl_msi: " Uwe Kleine-König
2012-10-15 16:14 ` Tabi Timur-B04825
2012-07-23 9:13 ` [PATCH 16/25] powerpc/celleb_pci: " Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 17/25] watchdog/mpc8xxx: " Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 18/25] can: mpc5xxx_can: make data in mpc5xxx_can_probe const Uwe Kleine-König
2012-07-23 9:17 ` Marc Kleine-Budde
2012-07-23 9:13 ` [PATCH 19/25] of: add const to struct *of_device_id.data Uwe Kleine-König
2012-07-23 15:32 ` Greg Kroah-Hartman
2012-07-23 9:13 ` [PATCH 20/25] gpio/gpio-omap: make platformdata used as *of_device_id.data const Uwe Kleine-König
2012-07-29 16:15 ` Linus Walleij
2012-07-29 21:27 ` Shilimkar, Santosh
2012-07-30 7:17 ` Uwe Kleine-König
2012-07-30 7:20 ` Shilimkar, Santosh
2012-07-23 9:13 ` [PATCH 21/25] powerpc/fsl_msi: drop unneeded cast to non-const pointer Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 22/25] mfd/da9052: make i2c_device_id array const Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 23/25] i2c/mpc: make data used as *of_device_id.data const Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 24/25] macintosh/mediabay: " Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 25/25] can: mpc5xxx_can: " Uwe Kleine-König
2012-07-23 9:20 ` Marc Kleine-Budde
2012-07-24 15:01 ` Arnd Bergmann [this message]
2012-08-05 8:54 ` [PATCH v2 00/25] make *struct of_device_id.data const Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207241501.48302.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox