From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 4/7] ARM: pxa: add devicetree code for irq handling
Date: Tue, 31 Jul 2012 12:18:43 +0000 [thread overview]
Message-ID: <201207311218.43440.arnd@arndb.de> (raw)
In-Reply-To: <50165466.1020901@gmail.com>
On Monday 30 July 2012, Daniel Mack wrote:
> On 30.07.2012 10:55, Haojian Zhuang wrote:
> > On Mon, Jul 30, 2012 at 4:34 PM, Daniel Mack <zonque@gmail•com> wrote:
> >> On 30.07.2012 10:31, Arnd Bergmann wrote:
> >>> On Sunday 29 July 2012, Daniel Mack wrote:
> >>>> And I also wonder whether using the second spec value for a priority
> >>>> wouldn't be somehow abusive? Isn't that considered to denote the trigger
> >>>> flags in contexts of interrupt controllers? At least, that is what
> >>>> irq_domain_xlate_twocell() assumes.
> >>>
> >>> You would not use irq_domain_xlate_twocell in that scenario but provide your
> >>> own, which is ok. Interpreting the second cell as the trigger flags is just
> >>> a convenient default because it's the most common use for that.
> >>
> >> I see. Don't know how much sense it makes to have that detail
> >> configurable though. Haojian? And I think we can still change that
> >> detail later.
> >>
> > Arnd's suggestion is good. So we can setup each interrupt's priority
> > while parsing
> > all these pxa interrupts. In current code, we only assign priority
> > with the irq number.
> > Maybe it's not perfect solution. For example, Timer interrupt should
> > have highest
> > priority. LCD interrupt also has higher priority.
>
> Arnd mentioned that instead of using the default
> irq_domain_xlate_onecell(), we can hook up our own translation function.
> While that is true, I wonder how that value that we send back in
> *out_type will ever appear in the irq_chip callbacks. Looking at the
> code that calls ->xlate(), I can see that irq_create_of_mapping() would
> call irq_set_irq_type() with our passed value, which will then &= it
> with IRQ_TYPE_SENSE_MASK (which is 0xf which doesn't suffice for our up
> to 96 interrupts).
>
> Arnd, either I don't get your point, or this would need some changes in
> the irqdomain core. Could you elaborate a little?
When you have your own xlate function, you would still always set the default
flags (IRQ_TYPE_NONE), but you do record the priority from the flags
in the same way that at91_aic_irq_domain_xlate does.
Arnd
next prev parent reply other threads:[~2012-07-31 12:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 19:16 [PATCH v2 0/7] Assorted PXA3xx DT patches Daniel Mack
2012-07-26 19:16 ` [PATCH v2 1/7] RTC: add DT bindings to pxa-rtc Daniel Mack
2012-07-26 19:16 ` [PATCH v2 2/7] MMC: pxa-mci: add DT bindings Daniel Mack
2012-07-26 19:16 ` [PATCH v2 3/7] MTD: pxa3xx-nand: add devicetree bindings Daniel Mack
2012-07-26 19:16 ` [PATCH v2 4/7] ARM: pxa: add devicetree code for irq handling Daniel Mack
2012-07-28 7:17 ` Haojian Zhuang
2012-07-28 9:56 ` Daniel Mack
2012-07-28 15:42 ` Haojian Zhuang
2012-07-29 14:09 ` Arnd Bergmann
2012-07-29 20:40 ` Daniel Mack
2012-07-30 8:31 ` Arnd Bergmann
2012-07-30 8:34 ` Daniel Mack
2012-07-30 8:55 ` Haojian Zhuang
2012-07-30 9:31 ` Daniel Mack
2012-07-31 12:18 ` Arnd Bergmann [this message]
2012-07-29 15:08 ` Daniel Mack
2012-07-29 15:54 ` Haojian Zhuang
2012-07-29 19:01 ` Daniel Mack
2012-07-30 1:20 ` Haojian Zhuang
2012-07-30 1:24 ` Haojian Zhuang
2012-07-30 7:11 ` Daniel Mack
2012-07-29 16:13 ` Haojian Zhuang
2012-07-26 19:16 ` [PATCH v2 5/7] ARM: pxa3xx: skip default device initialization when booting via DT Daniel Mack
2012-07-26 19:16 ` [PATCH v2 6/7] ARM: pxa3xx: add generic DT machine code Daniel Mack
2012-07-26 19:16 ` [PATCH v2 7/7] ARM: pxa: add .dtsi files Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207311218.43440.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox