From: tony@atomide•com (Tony Lindgren)
To: linux-arm-kernel@lists•infradead.org
Subject: [linux-pm] [PATCH v4 2/4] mfd: omap: control: core system control driver
Date: Wed, 8 Aug 2012 07:10:51 -0700 [thread overview]
Message-ID: <20120808141051.GG11011@atomide.com> (raw)
In-Reply-To: <20120808140507.GF11011@atomide.com>
* Tony Lindgren <tony@atomide•com> [120808 07:05]:
> * Konstantin Baydarov <kbaidarov@dev•rtsoft.ru> [120725 04:10]:
> > +
> > +u32 omap_control_status_read(void)
> > +{
> > + return __raw_readl(omap_control_base);
> > +}
>
> Ah OK it's changed here.. Sorry I was looking at the older
> version.
>
> > +void __init of_omap_control_init(const struct of_device_id *matches)
> > +{
> > + struct device_node *np;
> > + struct property *pp = 0;
> > +
> > + for_each_matching_node(np, matches) {
> > + pp = of_find_property(np, "reg", NULL);
> > + if(pp) {
> > + omap_control_phys_base = (unsigned long)be32_to_cpup(pp->value);
> > + omap_control_mapsize = (size_t)be32_to_cpup( (void*)((char*)pp->value + 4) );
> > + /*
> > + * Map control module register CONTROL_STATUS register:
> > + * omap24xx - OMAP24XX_CONTROL_STATUS
> > + * am33xx - AM33XX_CONTROL_STATUS
> > + * omap34xx - OMAP343X_CONTROL_STATUS
> > + * omap44xx - OMAP4_CTRL_MODULE_CORE_STATUS
> > + * omap54xx - OMAP5XXX_CONTROL_STATUS
> > + */
> > + omap_control_base = ioremap(omap_control_phys_base, omap_control_mapsize);
> > + }
> > + }
> > +}
>
> You should probably add a function for setting omap_control_base
> separately from *set_globals* in arch/arm/mach-omap2/common.c.
> That way it's initialized early for id.c, and you can initialize
> everything else later as regular device drivers.
>
> FYI, we want to initialize as much as possible late so we have
> proper debugging console set up in case things go wrong.
Hmm it seems that omap_control_base is now only initialized for DT boot
case? This will break booting on almost all systems..
Tony
next prev parent reply other threads:[~2012-08-08 14:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 11:05 [PATCH v4 2/4] mfd: omap: control: core system control driver Konstantin Baydarov
2012-07-25 11:07 ` Felipe Balbi
2012-08-08 14:05 ` Tony Lindgren
2012-08-08 14:10 ` Tony Lindgren [this message]
2012-08-08 14:39 ` [linux-pm] " Tony Lindgren
2012-08-08 14:59 ` Konstantin Baydarov
2012-08-09 6:18 ` Tony Lindgren
2012-08-09 11:00 ` Konstantin Baydarov
2012-08-10 8:50 ` Tony Lindgren
2012-08-29 12:33 ` AnilKumar, Chimata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120808141051.GG11011@atomide.com \
--to=tony@atomide$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox