From: olof@lixom•net (Olof Johansson)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 08/31] arm64: CPU support
Date: Tue, 14 Aug 2012 17:10:43 -0700 [thread overview]
Message-ID: <20120815001043.GD19607@quad.lixom.net> (raw)
In-Reply-To: <1344966752-16102-9-git-send-email-catalin.marinas@arm.com>
Hi,
On Tue, Aug 14, 2012 at 06:52:09PM +0100, Catalin Marinas wrote:
> diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
> new file mode 100644
> index 0000000..ef54125
> --- /dev/null
> +++ b/arch/arm64/include/asm/cputype.h
> @@ -0,0 +1,49 @@
> +/*
> + * Copyright (C) 2012 ARM Ltd.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program. If not, see <http://www.gnu.org/licenses/>.
> + */
> +#ifndef __ASM_CPUTYPE_H
> +#define __ASM_CPUTYPE_H
> +
> +#define ID_MIDR_EL1 "midr_el1"
> +#define ID_CTR_EL0 "ctr_el0"
> +
> +#define ID_AA64PFR0_EL1 "id_aa64pfr0_el1"
> +#define ID_AA64DFR0_EL1 "id_aa64dfr0_el1"
> +#define ID_AA64AFR0_EL1 "id_aa64afr0_el1"
> +#define ID_AA64ISAR0_EL1 "id_aa64isar0_el1"
> +#define ID_AA64MMFR0_EL1 "id_aa64mmfr0_el1"
> +
> +#define read_cpuid(reg) ({ \
> + u64 __val; \
> + asm("mrs %0, " reg : "=r" (__val)); \
> + __val; \
> +})
> +
> +/*
> + * The CPU ID never changes at run time, so we might as well tell the
> + * compiler that it's constant. Use this function to read the CPU ID
> + * rather than directly reading processor_id or read_cpuid() directly.
> + */
> +static inline u32 __attribute_const__ read_cpuid_id(void)
> +{
> + return read_cpuid(ID_MIDR_EL1);
> +}
> +
> +static inline u32 __attribute_const__ read_cpuid_cachetype(void)
> +{
> + return read_cpuid(ID_CTR_EL0);
> +}
Is this perhaps a carry-over from arch/arm? Abstracting out read_cpuid()
doesn't seem to buy anything here, just opencode the one-line assembly
in each.
Might as well cleanup the naming a little too while you're at it, i.e.
read_cpu_id() and read_cpu_cachetype().
> diff --git a/arch/arm64/include/asm/procinfo.h b/arch/arm64/include/asm/procinfo.h
> new file mode 100644
> index 0000000..81fece9
> --- /dev/null
> +++ b/arch/arm64/include/asm/procinfo.h
> @@ -0,0 +1,44 @@
> +/*
> + * Based on arch/arm/include/asm/procinfo.h
> + *
> + * Copyright (C) 1996-1999 Russell King
> + * Copyright (C) 2012 ARM Ltd.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program. If not, see <http://www.gnu.org/licenses/>.
> + */
> +#ifndef __ASM_PROCINFO_H
> +#define __ASM_PROCINFO_H
> +
> +#ifdef __KERNEL__
> +
> +/*
> + * Note! struct processor is always defined if we're
> + * using MULTI_CPU, otherwise this entry is unused,
> + * but still exists.
Stale comment?
> + *
> + * NOTE! The following structure is defined by assembly
> + * language, NOT C code. For more information, check:
> + * arch/arm/mm/proc-*.S and arch/arm/kernel/head.S
Stale references. Also, no current arm64 implementation uses this. Premature
abstraction perhaps?
> +struct proc_info_list {
> + unsigned int cpu_val;
> + unsigned int cpu_mask;
> + unsigned long __cpu_flush; /* used by head.S */
> + const char *cpu_name;
> +};
> +
> +#else /* __KERNEL__ */
> +#include <asm/elf.h>
> +#warning "Please include asm/elf.h instead"
> +#endif /* __KERNEL__ */
> +#endif
> diff --git a/arch/arm64/mm/proc-syms.c b/arch/arm64/mm/proc-syms.c
> new file mode 100644
> index 0000000..2d99ef9
> --- /dev/null
> +++ b/arch/arm64/mm/proc-syms.c
> @@ -0,0 +1,31 @@
> +/*
> + * Based on arch/arm/mm/proc-syms.c
> + *
> + * Copyright (C) 2000-2002 Russell King
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program. If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#include <linux/export.h>
> +#include <linux/mm.h>
> +
> +#include <asm/cacheflush.h>
> +#include <asm/proc-fns.h>
> +#include <asm/tlbflush.h>
> +#include <asm/page.h>
> +
> +EXPORT_SYMBOL(__cpuc_flush_kern_all);
> +EXPORT_SYMBOL(__cpuc_flush_user_all);
> +EXPORT_SYMBOL(__cpuc_flush_user_range);
> +EXPORT_SYMBOL(__cpuc_coherent_kern_range);
> +EXPORT_SYMBOL(__cpuc_flush_dcache_area);
See comment on other email about putting function pointers in a struct
instead.
> diff --git a/arch/arm64/mm/proc.S b/arch/arm64/mm/proc.S
> new file mode 100644
> index 0000000..453f517
> --- /dev/null
> +++ b/arch/arm64/mm/proc.S
> @@ -0,0 +1,193 @@
> + .section ".proc.info.init", #alloc, #execinstr
> +
> + .type __v8_proc_info, #object
> +__v8_proc_info:
> + .long 0x000f0000 // Required ID value
> + .long 0x000f0000 // Mask for ID
> + b __cpu_setup
> + nop
> + .quad cpu_name
> + .long 0
> + .size __v8_proc_info, . - __v8_proc_info
I know this is a carry-over from arch/arm, but how about moving this
to more of a C construct similar to arch/powerpc/kernel/cputable.c
instead? It's considerably easier to read that way, and it's convenient
to have the definitions all in one place, making it easier to share some
of the functions, etc.
-Olof
next prev parent reply other threads:[~2012-08-15 0:10 UTC|newest]
Thread overview: 170+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 17:52 [PATCH v2 00/31] AArch64 Linux kernel port Catalin Marinas
2012-08-14 17:52 ` [PATCH v2 01/31] arm64: Assembly macros and definitions Catalin Marinas
2012-08-15 12:57 ` Arnd Bergmann
2012-08-14 17:52 ` [PATCH v2 02/31] arm64: Kernel booting and initialisation Catalin Marinas
2012-08-14 23:06 ` Olof Johansson
2012-08-15 17:37 ` Catalin Marinas
2012-08-15 19:03 ` Olof Johansson
2012-08-15 19:53 ` Catalin Marinas
2012-08-15 13:20 ` Arnd Bergmann
2012-08-15 17:06 ` Olof Johansson
2012-08-16 12:53 ` Catalin Marinas
2012-08-16 18:59 ` Nicolas Pitre
2012-08-17 11:20 ` Arnd Bergmann
2012-08-17 13:45 ` Catalin Marinas
2012-08-17 18:21 ` Nicolas Pitre
2012-08-17 8:56 ` Tony Lindgren
2012-08-17 9:41 ` Santosh Shilimkar
2012-08-17 10:05 ` Catalin Marinas
2012-08-17 10:10 ` Shilimkar, Santosh
2012-08-17 13:13 ` Tony Lindgren
2012-08-17 13:48 ` Catalin Marinas
2012-08-24 9:50 ` Catalin Marinas
2012-08-14 17:52 ` [PATCH v2 03/31] arm64: Exception handling Catalin Marinas
2012-08-14 23:29 ` Olof Johansson
2012-08-14 23:47 ` Thomas Gleixner
2012-08-15 13:03 ` Arnd Bergmann
2012-08-16 10:05 ` Will Deacon
2012-08-16 11:54 ` Arnd Bergmann
2012-08-14 17:52 ` [PATCH v2 04/31] arm64: MMU definitions Catalin Marinas
2012-08-15 13:30 ` Arnd Bergmann
2012-08-15 13:39 ` Catalin Marinas
2012-08-15 16:34 ` Geert Uytterhoeven
2012-08-15 16:45 ` Catalin Marinas
2012-08-17 9:04 ` Tony Lindgren
2012-08-17 9:21 ` Catalin Marinas
2012-08-17 9:38 ` Tony Lindgren
2012-08-14 17:52 ` [PATCH v2 05/31] arm64: MMU initialisation Catalin Marinas
2012-08-15 13:45 ` Arnd Bergmann
2012-08-17 10:06 ` Santosh Shilimkar
2012-08-17 10:15 ` Catalin Marinas
2012-08-17 10:25 ` Shilimkar, Santosh
2012-08-14 17:52 ` [PATCH v2 06/31] arm64: MMU fault handling and page table management Catalin Marinas
2012-08-15 13:47 ` Arnd Bergmann
2012-08-17 16:07 ` Catalin Marinas
2012-08-14 17:52 ` [PATCH v2 07/31] arm64: Process management Catalin Marinas
2012-08-14 23:50 ` Olof Johansson
2012-09-14 17:33 ` Catalin Marinas
2012-09-16 0:29 ` Olof Johansson
2012-08-15 13:53 ` Arnd Bergmann
2012-08-17 16:15 ` Catalin Marinas
2012-08-16 15:09 ` Tobias Klauser
2012-08-14 17:52 ` [PATCH v2 08/31] arm64: CPU support Catalin Marinas
2012-08-15 0:10 ` Olof Johansson [this message]
2012-08-20 15:57 ` Catalin Marinas
2012-08-20 20:47 ` Arnd Bergmann
2012-08-21 9:50 ` Catalin Marinas
2012-09-14 17:38 ` Catalin Marinas
2012-08-15 13:56 ` Arnd Bergmann
2012-08-20 16:00 ` Catalin Marinas
2012-08-14 17:52 ` [PATCH v2 09/31] arm64: Cache maintenance routines Catalin Marinas
2012-08-17 9:57 ` Santosh Shilimkar
2012-08-17 10:07 ` Catalin Marinas
2012-08-17 10:12 ` Shilimkar, Santosh
2012-08-14 17:52 ` [PATCH v2 10/31] arm64: TLB maintenance functionality Catalin Marinas
2012-08-14 17:52 ` [PATCH v2 11/31] arm64: IRQ handling Catalin Marinas
2012-08-14 23:22 ` Aaro Koskinen
2012-08-14 17:52 ` [PATCH v2 12/31] arm64: Atomic operations Catalin Marinas
2012-08-15 0:21 ` Olof Johansson
2012-08-14 17:52 ` [PATCH v2 13/31] arm64: Device specific operations Catalin Marinas
2012-08-15 0:33 ` Olof Johansson
2012-09-14 17:29 ` Catalin Marinas
2012-09-14 17:31 ` Arnd Bergmann
2012-09-14 17:39 ` Catalin Marinas
2012-09-16 0:28 ` Olof Johansson
2012-08-15 16:13 ` Arnd Bergmann
2012-08-17 9:19 ` Tony Lindgren
2012-08-14 17:52 ` [PATCH v2 14/31] arm64: DMA mapping API Catalin Marinas
2012-08-15 0:40 ` Olof Johansson
2012-08-21 13:05 ` Catalin Marinas
2012-08-15 16:16 ` Arnd Bergmann
2012-08-21 12:59 ` Catalin Marinas
2012-08-14 17:52 ` [PATCH v2 15/31] arm64: SMP support Catalin Marinas
2012-08-15 0:49 ` Olof Johansson
2012-08-15 13:04 ` Arnd Bergmann
2012-08-17 9:21 ` Tony Lindgren
2012-08-17 9:32 ` Catalin Marinas
2012-08-17 9:39 ` Tony Lindgren
2012-08-14 17:52 ` [PATCH v2 16/31] arm64: ELF definitions Catalin Marinas
2012-08-15 14:15 ` Arnd Bergmann
2012-08-16 10:23 ` Will Deacon
2012-08-16 12:37 ` Arnd Bergmann
2012-08-21 16:06 ` Catalin Marinas
2012-08-21 18:17 ` Geert Uytterhoeven
2012-08-21 18:27 ` Catalin Marinas
2012-08-21 18:53 ` Mike Frysinger
2012-08-21 20:17 ` Arnd Bergmann
2012-09-05 19:56 ` Chris Metcalf
2012-08-14 17:52 ` [PATCH v2 17/31] arm64: System calls handling Catalin Marinas
2012-08-15 14:22 ` Arnd Bergmann
2012-08-21 17:51 ` Catalin Marinas
2012-08-21 20:14 ` Arnd Bergmann
2012-08-21 22:01 ` Catalin Marinas
2012-08-22 7:56 ` Arnd Bergmann
2012-08-22 10:29 ` Catalin Marinas
2012-08-22 12:27 ` Arnd Bergmann
2012-08-22 17:13 ` Catalin Marinas
2012-09-03 11:48 ` Catalin Marinas
2012-09-03 12:39 ` Arnd Bergmann
2012-08-14 17:52 ` [PATCH v2 18/31] arm64: VDSO support Catalin Marinas
2012-08-14 17:52 ` [PATCH v2 19/31] arm64: Signal handling support Catalin Marinas
2012-08-14 17:52 ` [PATCH v2 20/31] arm64: User access library functions Catalin Marinas
2012-08-15 14:49 ` [PATCH v2 20/31] arm64: User access library function Arnd Bergmann
2012-09-03 12:58 ` Catalin Marinas
2012-09-05 19:13 ` Russell King - ARM Linux
2012-09-05 21:01 ` Catalin Marinas
2012-09-05 21:05 ` Russell King - ARM Linux
2012-09-06 8:36 ` Catalin Marinas
2012-08-14 17:52 ` [PATCH v2 21/31] arm64: 32-bit (compat) applications support Catalin Marinas
2012-08-15 14:34 ` Arnd Bergmann
2012-08-16 10:28 ` Will Deacon
2012-08-16 12:39 ` Arnd Bergmann
2012-08-23 6:46 ` PER_LINUX32, Was: " Arnd Bergmann
2012-08-23 10:42 ` Catalin Marinas
2012-08-28 18:28 ` Jiri Kosina
2012-08-24 10:43 ` Catalin Marinas
2012-08-26 4:49 ` Arnd Bergmann
2012-08-20 10:53 ` Pavel Machek
2012-08-20 20:34 ` Arnd Bergmann
2012-08-21 10:28 ` Pavel Machek
2012-08-14 17:52 ` [PATCH v2 22/31] arm64: Floating point and SIMD Catalin Marinas
2012-08-15 14:35 ` Arnd Bergmann
2012-08-14 17:52 ` [PATCH v2 23/31] arm64: Debugging support Catalin Marinas
2012-08-15 15:07 ` Arnd Bergmann
2012-08-16 10:47 ` Will Deacon
2012-08-16 12:49 ` Arnd Bergmann
2012-08-17 7:06 ` Arnd Bergmann
2012-08-20 9:07 ` Will Deacon
2012-08-20 9:27 ` Will Deacon
2012-08-20 20:10 ` Arnd Bergmann
2012-08-21 8:58 ` Will Deacon
2012-08-14 17:52 ` [PATCH v2 24/31] arm64: Add support for /proc/sys/debug/exception-trace Catalin Marinas
2012-08-15 15:08 ` Arnd Bergmann
2012-08-14 17:52 ` [PATCH v2 25/31] arm64: Performance counters support Catalin Marinas
2012-08-15 15:11 ` Arnd Bergmann
2012-08-16 10:51 ` Will Deacon
2012-08-14 17:52 ` [PATCH v2 26/31] arm64: Miscellaneous library functions Catalin Marinas
2012-08-15 15:21 ` Arnd Bergmann
2012-08-16 10:57 ` Will Deacon
2012-08-16 13:00 ` Arnd Bergmann
2012-08-16 14:11 ` Catalin Marinas
2012-08-14 17:52 ` [PATCH v2 27/31] arm64: Loadable modules Catalin Marinas
2012-08-15 15:23 ` Arnd Bergmann
2012-08-15 15:35 ` Catalin Marinas
2012-08-15 16:16 ` Arnd Bergmann
2012-08-14 17:52 ` [PATCH v2 28/31] arm64: Generic timers support Catalin Marinas
2012-08-15 15:52 ` Arnd Bergmann
2012-08-16 12:40 ` Linus Walleij
2012-08-17 9:29 ` Tony Lindgren
2012-08-17 10:21 ` Santosh Shilimkar
2012-08-21 19:20 ` Christopher Covington
2012-08-14 17:52 ` [PATCH v2 29/31] arm64: Miscellaneous header files Catalin Marinas
2012-08-15 15:56 ` Arnd Bergmann
2012-08-14 17:52 ` [PATCH v2 30/31] arm64: Build infrastructure Catalin Marinas
2012-08-14 21:01 ` Sam Ravnborg
2012-08-15 16:07 ` Arnd Bergmann
2012-08-17 9:32 ` Tony Lindgren
2012-08-17 9:46 ` Catalin Marinas
2012-08-14 17:52 ` [PATCH v2 31/31] arm64: MAINTAINERS update Catalin Marinas
2012-08-15 15:57 ` Arnd Bergmann
2012-08-17 9:36 ` [PATCH v2 00/31] AArch64 Linux kernel port Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120815001043.GD19607@quad.lixom.net \
--to=olof@lixom$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox