From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [v3] Add basic address decoding support for Marvell 370/XP
Date: Sun, 19 Aug 2012 14:16:03 +0000 [thread overview]
Message-ID: <201208191416.03873.arnd@arndb.de> (raw)
In-Reply-To: <20120819012303.GX22226@titan.lakedaemon.net>
On Sunday 19 August 2012, Jason Cooper wrote:
> On Fri, Aug 17, 2012 at 03:21:56PM +0200, Thomas Petazzoni wrote:
> > Le Thu, 16 Aug 2012 14:37:08 -0400,
> > Jason Cooper <jason@lakedaemon•net> a ?crit :
> >
> > > > Whole series applied to:
> > > >
> > > > git://git.infradead.org/users/jcooper/linux.git boards-for-v3.7
> > >
> > > I'm getting the following build error with orion_nand enabled:
> > >
> > > CC drivers/mtd/nand/orion_nand.o
> > > drivers/mtd/nand/orion_nand.c:24:27: fatal error: mach/hardware.h: No
> > > such file or directory
> > > compilation terminated.
> >
> > Are you perhaps trying to enable the orion_nand driver for a mach-mvebu
> > platform (Armada 370 or XP)? If it's the case, then yes, this build
> > breakage is expected: we haven't enabled any of the I/O for now, so we
> > don't have hardware.h yet. This is not something that is broken due to
> > the address decoding changes.
>
> Ok, I've added Arnd and Olof to the CC. The above is exactly what I
> did.
>
> Arnd, how extensive is the 'make randconfig' testing in next? Is this
> something that needs to be fixed before we push? I found it by a fluke,
> but the right randconfig would light it up as well.
If there is a bug you know about, you should fix it. In the above
example, I would guess that you should not actually need to include
mach/hardware.h, so the fix should be simple. In general, we should
eliminate mach/hardware.h where we can and put register locations
into resource, and offsets into the drivers themselves.
Arnd
next prev parent reply other threads:[~2012-08-19 14:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 9:42 [v3] Add basic address decoding support for Marvell 370/XP Thomas Petazzoni
2012-08-06 9:42 ` [PATCH 1/5] arm: plat-orion: use 'void __iomem *' in addr-map code Thomas Petazzoni
2012-08-06 9:42 ` [PATCH 2/5] arm: plat-orion: introduce PLAT_ORION_LEGACY hidden config option Thomas Petazzoni
2012-08-06 9:42 ` [PATCH 3/5] arm: plat-orion: make bridge_virt_base non-const to support DT use case Thomas Petazzoni
2012-08-06 9:42 ` [PATCH 4/5] arm: mvebu: add basic address decoding support to Armada 370/XP Thomas Petazzoni
2012-08-06 9:42 ` [PATCH 5/5] arm: mvebu: add address decoding controller to the DT Thomas Petazzoni
2012-08-16 13:28 ` [v3] Add basic address decoding support for Marvell 370/XP Jason Cooper
2012-08-16 18:37 ` Jason Cooper
2012-08-17 13:21 ` Thomas Petazzoni
2012-08-19 1:23 ` Jason Cooper
2012-08-19 14:16 ` Arnd Bergmann [this message]
2012-08-21 9:46 ` Thomas Petazzoni
2012-08-21 10:37 ` Sebastian Hesselbarth
2012-08-21 11:50 ` Thomas Petazzoni
2012-08-21 12:45 ` Sebastian Hesselbarth
2012-08-27 23:35 ` Fix orion_nand build on ARCH_MVEBU Thomas Petazzoni
2012-08-27 23:35 ` [PATCH] mtd: orion_nand: remove <mach/hardware.h> include Thomas Petazzoni
2012-08-28 9:11 ` Andrew Lunn
2012-08-28 9:31 ` Sebastian Hesselbarth
2012-08-28 12:22 ` Thomas Petazzoni
2012-08-28 18:12 ` Jason Cooper
2012-08-29 15:46 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208191416.03873.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox