From: plagnioj@jcrosoft•com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 5/6] ARM: integrator: convert AMBA devices to device tree
Date: Mon, 20 Aug 2012 10:02:10 +0200 [thread overview]
Message-ID: <20120820080210.GF7439@game.jcrosoft.org> (raw)
In-Reply-To: <CACRpkdZDMxk30YTkrumRveR3OuWptSpzNevrAvC2FxYShOZp-A@mail.gmail.com>
On 00:42 Sun 19 Aug , Linus Walleij wrote:
> On Thu, Aug 16, 2012 at 2:40 PM, Jean-Christophe PLAGNIOL-VILLARD
> <plagnioj@jcrosoft•com> wrote:
> > On 14:16 Thu 16 Aug , Linus Walleij wrote:
> >> +/* For the Device Tree, add in the UART callbacks as AUXDATA */
> >> +static struct of_dev_auxdata ap_auxdata_lookup[] __initdata = {
> >> + OF_DEV_AUXDATA("arm,primecell", INTEGRATOR_RTC_BASE,
> >> + "rtc", NULL),
> >> + OF_DEV_AUXDATA("arm,primecell", INTEGRATOR_UART0_BASE,
> >> + "uart0", &integrator_uart_data),
> >> + OF_DEV_AUXDATA("arm,primecell", INTEGRATOR_UART1_BASE,
> >> + "uart1", &integrator_uart_data),
> >> + OF_DEV_AUXDATA("arm,primecell", KMI0_BASE,
> >> + "kmi0", NULL),
> >> + OF_DEV_AUXDATA("arm,primecell", KMI1_BASE,
> >> + "kmi1", NULL),
> >> + { /* sentinel */ },
>
> > why that?
>
> Based on similar code by Grant in arch/arm/mach-versatile/core.c
> also ending with a {}. Also at other places ... I though this terminated
> the list iteration, is it not needed anymore?
no I mean why
> >> + OF_DEV_AUXDATA("arm,primecell", INTEGRATOR_RTC_BASE,
> >> + "rtc", NULL),
> >> + OF_DEV_AUXDATA("arm,primecell", KMI0_BASE,
> >> + "kmi0", NULL),
> >> + OF_DEV_AUXDATA("arm,primecell", KMI1_BASE,
> >> + "kmi1", NULL),
no platform data why do you use the AUXDATA?
as the OF_DEV_AUXDATA is deprecated now
Bset Regards,
J.
next prev parent reply other threads:[~2012-08-20 8:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 12:16 [PATCH 5/6] ARM: integrator: convert AMBA devices to device tree Linus Walleij
2012-08-16 12:40 ` Jean-Christophe PLAGNIOL-VILLARD
2012-08-18 22:42 ` Linus Walleij
2012-08-20 8:02 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-08-30 23:30 ` Linus Walleij
2012-08-16 13:56 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120820080210.GF7439@game.jcrosoft.org \
--to=plagnioj@jcrosoft$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox