From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: Kirkwood: Iomega_IX2_200 DT support Signed-off-by: Alan M Butler <alanbutty12@gmail•com>
Date: Mon, 20 Aug 2012 13:43:20 +0200 [thread overview]
Message-ID: <20120820114320.GB26837@lunn.ch> (raw)
In-Reply-To: <1d07faa52b5ca4453c7eaa7c9decb01af92ee648.1345459608.git.alanbutty12@gmail.com>
Hi Alan
Overall this is looking good.
Just a few minor comments below.
> diff --git a/arch/arm/mach-kirkwood/board-iomega_ix2_200.c b/arch/arm/mach-kirkwood/board-iomega_ix2_200.c
> new file mode 100644
> index 0000000..0c78752
> --- /dev/null
> +++ b/arch/arm/mach-kirkwood/board-iomega_ix2_200.c
> @@ -0,0 +1,79 @@
> +/*
> + * arch/arm/mach-kirkwood/board-iomega_ix2_200.c
> + *
> + * Iomega StorCenter ix2-200
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +
> +#include <linux/kernel.h>
> +#include <linux/init.h>
> +#include <linux/platform_device.h>
> +#include <linux/irq.h>
> +#include <linux/mtd/partitions.h>
> +#include <linux/ata_platform.h>
> +#include <linux/mv643xx_eth.h>
> +#include <linux/ethtool.h>
> +#include <net/dsa.h>
> +#include <linux/gpio.h>
> +#include <linux/leds.h>
> +#include <linux/i2c.h>
> +#include <asm/mach-types.h>
> +#include <asm/mach/arch.h>
> +#include <mach/kirkwood.h>
> +#include "common.h"
> +#include "mpp.h"
It would be good to remove all the unneeded include files.
> +
> +static struct mv643xx_eth_platform_data iomega_ix2_200_ge00_data = {
> + .phy_addr = MV643XX_ETH_PHY_NONE,
> + .speed = SPEED_1000,
> + .duplex = DUPLEX_FULL,
> +};
It is somewhat unusual to have this configuration, 1000 full. Is this
a hardware limitation? Or is the port connected to an internal switch?
Maybe add a comment why its hard coded.
Andrew
next prev parent reply other threads:[~2012-08-20 11:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1345459608.git.alanbutty12@gmail.com>
2012-08-20 11:16 ` [PATCH] ARM: Kirkwood: Iomega_IX2_200 DT support Signed-off-by: Alan M Butler <alanbutty12@gmail•com> Alan M Butler
2012-08-20 11:43 ` Andrew Lunn [this message]
2012-08-20 12:55 ` Alan M Butler
2012-08-20 13:25 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120820114320.GB26837@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox