public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: marek.vasut@gmail•com (Marek Vasut)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/4 V2] ARM: mxs: Update DENX M28 machine and dts file
Date: Sun, 26 Aug 2012 13:42:34 +0200	[thread overview]
Message-ID: <201208261342.34653.marex@denx.de> (raw)
In-Reply-To: <20120825080504.GL31998@S2101-09.ap.freescale.net>

Dear Shawn Guo,

> On Sat, Aug 25, 2012 at 01:51:39AM +0200, Marek Vasut wrote:
> > +
> > +		reg_vddio_sd0: vddio-sd0 {
> > +			compatible = "regulator-fixed";
> > +			regulator-name = "vddio-sd0";
> > +			regulator-min-microvolt = <3300000>;
> > +			regulator-max-microvolt = <3300000>;
> > +			gpio = <&gpio3 28 0>;
> > +		};
> > +
> > +		reg_usb0_vbus: usb0_vbus {
> > +			compatible = "regulator-fixed";
> > +			regulator-name = "usb0_vbus";
> > +			regulator-min-microvolt = <5000000>;
> > +			regulator-max-microvolt = <5000000>;
> > +			gpio = <&gpio3 12 0>;
> > +			enable-active-low;
> 
> Documentation/devicetree/bindings/regulator/fixed-regulator.txt:
> 
> - enable-active-high: Polarity of GPIO is Active high
> If this property is missing, the default assumed is Active low.
> 
> I suspect you need to recheck this aspect for all these 3 fixed
> regulators.

Ok, so the prop had no impact? I'll retest and resubmit. Also, put the SPS1 on 
hold until the led issue is done for.

Thanks

> > +		};
> > +
> > +		reg_usb1_vbus: usb1_vbus {
> > +			compatible = "regulator-fixed";
> > +			regulator-name = "usb1_vbus";
> > +			regulator-min-microvolt = <5000000>;
> > +			regulator-max-microvolt = <5000000>;
> > +			gpio = <&gpio3 13 0>;
> > +			enable-active-low;
> > +		};

Best regards,
Marek Vasut

  reply	other threads:[~2012-08-26 11:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-24 23:51 [PATCH 1/4 V2] ARM: mx28: Add SPI 2 pinmux into imx28.dtsi Marek Vasut
2012-08-24 23:51 ` [PATCH 2/4 V2] ARM: mx28: Add USB PHY overcurrent pinmux Marek Vasut
2012-08-25  7:57   ` Shawn Guo
2013-11-22 15:49   ` Michael Grzeschik
2013-11-23 14:48     ` Peter Chen
2013-11-24 16:05       ` Michael Grzeschik
2013-11-24 23:58     ` Marek Vasut
2013-11-25 13:42       ` Michael Grzeschik
2013-11-26 12:08         ` Peter Chen
2013-12-06 15:17           ` Michael Grzeschik
2013-12-09  5:12             ` Peter Chen
2012-08-24 23:51 ` [PATCH 3/4 V2] ARM: mxs: Update DENX M28 machine and dts file Marek Vasut
2012-08-25  8:05   ` Shawn Guo
2012-08-26 11:42     ` Marek Vasut [this message]
2012-08-24 23:51 ` [PATCH 4/4] ARM: mxs: Add SchulerControl SPS1 DTS file Marek Vasut
2012-08-25  8:30   ` Shawn Guo
2012-08-25 12:35     ` Marek Vasut
2012-08-25 13:03       ` Shawn Guo
2012-08-28  0:28     ` Shawn Guo
2012-08-28  0:44       ` Marek Vasut
2012-08-25  7:56 ` [PATCH 1/4 V2] ARM: mx28: Add SPI 2 pinmux into imx28.dtsi Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201208261342.34653.marex@denx.de \
    --to=marek.vasut@gmail$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox