From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/4] ARM: ks-8695: merge the timer header into the timer driver
Date: Mon, 3 Sep 2012 13:01:00 +0000 [thread overview]
Message-ID: <201209031301.00691.arnd@arndb.de> (raw)
In-Reply-To: <1346264802-20306-1-git-send-email-linus.walleij@linaro.org>
On Wednesday 29 August 2012, Linus Walleij wrote:
> +#define KS8695_TMR_OFFSET (0xF0000 + 0xE400)
> +#define KS8695_TMR_VA (KS8695_IO_VA + KS8695_TMR_OFFSET)
> +#define KS8695_TMR_PA (KS8695_IO_PA + KS8695_TMR_OFFSET)
I'm not too happy about KS8695_TMR_VA moving into a device driver, but aside
from that the patch looks ok to me. Apparently, the gpio, ethernet, serial
and watchdog drivers for this platform already do it like this anyway.
ARnd
next prev parent reply other threads:[~2012-09-03 13:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 18:26 [PATCH 1/4] ARM: ks-8695: merge the timer header into the timer driver Linus Walleij
2012-08-31 6:25 ` Greg Ungerer
2012-09-03 13:01 ` Arnd Bergmann [this message]
2012-09-08 3:34 ` Olof Johansson
2012-09-08 9:45 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209031301.00691.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox