From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] ARM: initial multiplatform support
Date: Tue, 4 Sep 2012 06:56:23 +0000 [thread overview]
Message-ID: <201209040656.23536.arnd@arndb.de> (raw)
In-Reply-To: <5045280C.6060103@gmail.com>
On Monday 03 September 2012, Rob Herring wrote:
> On 09/03/2012 11:34 AM, Arnd Bergmann wrote:
> >> @@ -254,27 +254,9 @@ config MMU
> >> #
> >> choice
> >> prompt "ARM system type"
> >> + depends on !ARCH_MULTIPLATFORM
> >> default ARCH_VERSATILE
> >
> > Why did you move ARCH_MULTIPLATFORM out of the "choice" statement?
> > If we leave it in there, and make it the default, then we don't
> > even have to change the defconfigs any more (except the versatile
> > one, which is no longer the default), which I think is quite clever
> > and helps git-bisecting across this commit.
>
> We don't have to change and of the defconfigs or .config in this patch.
How does ARCH_MULTIPLATFORM get set then when building the existing
defconfig files for the converted platforms?
> > For instance, we could enable one platform to be used in
> > multiplatform kernels with the subset of its board files and
> > device drivers that are possible, while leaving board files
> > that cannot work with sparse-irq and drivers that rely on
> > platform specific headers as "depends on !ARCH_MULTIPLATFORM".
>
> Individual platforms can still do that. I just happened to convert all
> platforms which have no need to be in both. While you can do that, I
> don't think we should encourage it. I don't think we want to see
> platforms partially converted to common clk or sparse irq. The latter is
> certainly not hard to do.
I was thinking of other cases actually:
* device drivers that we don't really care about much but that rely
on a mach/* header file. In some cases it can be hard to clean up
those headers, so as an intermediate step, we can just disable the
drivers when building multiplatform.
* At least the Samsung platforms have files that are built for separate
platforms in a way that does not work across platforms:
arch/arm/plat-samsung/devs.c depends heavily on constants defined
in mach/*.h header files. When building for DT-only, we can decide to
just not build this file.
Arnd
next prev parent reply other threads:[~2012-09-04 6:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 22:49 [PATCH 0/6] Initial multi-platform support Rob Herring
2012-08-29 22:49 ` [PATCH 1/6] ARM: move ARCH config definitions into mach dirs Rob Herring
2012-08-29 23:14 ` H Hartley Sweeten
2012-08-29 23:31 ` Russell King - ARM Linux
2012-08-30 15:18 ` Rob Herring
2012-08-30 16:45 ` Russell King - ARM Linux
2012-08-30 19:07 ` Rob Herring
2012-08-30 19:28 ` Russell King - ARM Linux
2012-08-31 11:05 ` Domenico Andreoli
2012-08-31 11:11 ` Russell King - ARM Linux
2012-08-31 11:46 ` Domenico Andreoli
2012-09-01 0:48 ` Rob Herring
2012-09-02 8:49 ` Russell King - ARM Linux
2012-09-04 17:50 ` Tony Lindgren
2012-08-29 22:49 ` [PATCH 2/6] ARM: introduce Kconfig.mach Rob Herring
2012-08-29 23:18 ` H Hartley Sweeten
2012-08-29 22:49 ` [PATCH 3/6] ARM: picoxcell: header fixes for multi-platform Rob Herring
2012-08-29 22:49 ` [PATCH 4/6] ARM: vexpress: remove dependency on mach/* headers Rob Herring
2012-08-29 22:49 ` [PATCH 5/6] ARM: initial multiplatform support Rob Herring
2012-08-29 22:50 ` [PATCH 6/6] ARM: update defconfigs Rob Herring
2012-08-31 18:12 ` [PATCH v2] ARM: initial multiplatform support Rob Herring
2012-09-03 16:34 ` Arnd Bergmann
2012-09-03 21:58 ` Rob Herring
2012-09-04 6:56 ` Arnd Bergmann [this message]
2012-09-04 22:40 ` Rob Herring
2012-09-05 10:36 ` Arnd Bergmann
2012-09-05 13:25 ` Rob Herring
2012-09-05 13:33 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209040656.23536.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox