From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/4] net: mvneta: driver for Marvell Armada 370/XP network unit
Date: Tue, 4 Sep 2012 14:36:36 +0000 [thread overview]
Message-ID: <201209041436.36430.arnd@arndb.de> (raw)
In-Reply-To: <1346764004-16332-2-git-send-email-thomas.petazzoni@free-electrons.com>
On Tuesday 04 September 2012, Thomas Petazzoni wrote:
> .../devicetree/bindings/net/marvell-neta.txt | 24 +
> drivers/net/ethernet/marvell/Kconfig | 11 +
> drivers/net/ethernet/marvell/Makefile | 1 +
> drivers/net/ethernet/marvell/mvneta.c | 2732 ++++++++++++++++++++
> drivers/net/ethernet/marvell/mvneta.h | 496 ++++
> 5 files changed, 3264 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/marvell-neta.txt
> create mode 100644 drivers/net/ethernet/marvell/mvneta.c
> create mode 100644 drivers/net/ethernet/marvell/mvneta.h
I usually prefer putting the definitions into the .c file rather
than a separate header if there is only only file including it
anyway.
> diff --git a/Documentation/devicetree/bindings/net/marvell-neta.txt b/Documentation/devicetree/bindings/net/marvell-neta.txt
> new file mode 100644
> index 0000000..a031978
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/marvell-neta.txt
> @@ -0,0 +1,24 @@
> +* Marvell Armada 370 / Armada XP Ethernet Controller (NETA)
> +
> +Required properties:
> +- compatible: should be "marvell,neta".
> +- reg: address and length of the register set for the device.
> +- interrupts: interrupt for the device
> +- phy-mode: String, operation mode of the PHY interface. Supported
> + values are "sgmii" and "rmii".
> +- phy-addr: Integer, address of the PHY.
> +- device_type: should be "network".
> +- clock-frequency: frequency of the peripheral clock of the SoC.
> +
> +Example:
> +
> +eth at d0070000 {
> + compatible = "marvell,neta";
> + reg = <0xd0070000 0x2500>;
> + interrupts = <8>;
> + device_type = "network";
> + clock-frequency = <250000000>;
> + status = "okay";
> + phy-mode = "sgmii";
> + phy-addr = <25>;
I think we normally put the phy into a separate device node on an
mdio bus and then use the of_phy_* functions to connect it to
the ethernet device.
Arnd
next prev parent reply other threads:[~2012-09-04 14:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 13:06 net: Network driver for the Armada 370 and Armada XP ARM Marvell SoCs Thomas Petazzoni
2012-09-04 13:06 ` [PATCH 1/4] net: mvneta: driver for Marvell Armada 370/XP network unit Thomas Petazzoni
2012-09-04 14:36 ` Arnd Bergmann [this message]
2012-09-04 15:56 ` Thomas Petazzoni
2012-09-04 18:31 ` Andrew Lunn
2012-09-05 7:32 ` Thomas Petazzoni
2012-09-05 15:25 ` Florian Fainelli
2012-09-04 13:06 ` [PATCH 2/4] net: mvneta: update MAINTAINERS file for the mvneta maintainers Thomas Petazzoni
2012-09-04 13:06 ` [PATCH 3/4] arm: mvebu: add Ethernet controllers using mvneta driver for Armada 370/XP Thomas Petazzoni
2012-09-04 13:06 ` [PATCH 4/4] arm: mvebu: enable Ethernet controllers on Armada 370/XP eval boards Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2012-10-23 16:54 [PATCH v3] Network driver for the Armada 370 and Armada XP ARM Marvell SoCs Thomas Petazzoni
2012-10-23 16:54 ` [PATCH 1/4] net: mvneta: driver for Marvell Armada 370/XP network unit Thomas Petazzoni
2012-10-25 3:06 ` David Miller
2012-10-25 6:21 ` Thomas Petazzoni
2012-10-26 10:03 [PATCH v4] Network driver for the Armada 370 and Armada XP ARM Marvell SoCs Thomas Petazzoni
2012-10-26 10:03 ` [PATCH 1/4] net: mvneta: driver for Marvell Armada 370/XP network unit Thomas Petazzoni
2012-10-30 12:07 ` Nobuhiro Iwamatsu
2012-10-30 12:28 ` Thomas Petazzoni
2012-10-31 11:12 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209041436.36430.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox