public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed

From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] ARM: Kirkwood: ehci-orion: Add device tree binding
Date: Mon, 24 Sep 2012 09:13:53 +0200	[thread overview]
Message-ID: <20120924071353.GA27099@lunn.ch> (raw)
In-Reply-To: <CAOesGMh1x8QMNBi_xKEfZ0druiAZbafVuXEQkktwVbQODDmR8w@mail.gmail.com>

> > +Required properties:
> > +- compatible: must be "marvell,orion-ehci"
> > +- reg: physical base address of the controller and length of memory mapped
> > +  region.
> > +- interrupts: The EHCI interrupt
> > +- phy-version: Can be one of:
> > +  "NA" - Don't touch the phy, something else has already configured it.
> > +  "orion5x" - PHY setup as specified by the Orion5x Errata
> > +
> > +Example:
> > +
> > +       ehci at 50000 {
> > +               compatible = "marvell,orion-ehci";
> > +               reg = <0x50000 0x1000>;
> > +               interrupts = <19>;
> > +               phy-version = "NA";
> > +       };
> 
> This isn't an appropriate binding for phy. I know, it maps straight
> over from the platform data, but it doesn't focus on what the actual
> hardware is.
> 
> A couple of options. What probably makes most sense depending on how
> other phy bindings are moving ahead is to add a phy node under the
> ehci controller for the "orion5x" case, and have an appropriate
> compatible value there. No node means the same as "NA" in the above
> binding. Alternatively, have a phy phandle that points to the phy
> device if it sits on an i2c bus, etc.

I Olaf

Could i suggest a third option:

I just drop USB phy configuration all together.  Only mach-orion5x
needs this and nobody has shown any interest in moving mach-orion5x to
DT. So i would just hard code it to "NA".

If anybody does show interest in DT for orion5x, we can add a phy node
under ehci as a pure extension which does not affect backward
compatibility.

	Thanks
		Andrew

next prev parent reply	other threads:[~2012-09-24  7:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-01  9:26 [PATCH 1/2] ARM: Kirkwood: ehci-orion: Add device tree binding Andrew Lunn
2012-09-01  9:26 ` [PATCH 2/2] ARM: Kirkwood: Convert all DT boards to EHCI via DT Andrew Lunn
2012-09-09 19:12   ` Jason Cooper
2012-09-03  6:56 ` [PATCH 1/2] ARM: Kirkwood: ehci-orion: Add device tree binding Sebastian Hesselbarth
2012-09-04 15:06 ` Alan Stern
2012-09-09 19:11 ` Jason Cooper
2012-09-22  5:02 ` Olof Johansson
2012-09-24  7:13   ` Andrew Lunn [this message]
2012-09-26 23:49     ` Olof Johansson
2012-10-17 15:18       ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120924071353.GA27099@lunn.ch \
    --to=andrew@lunn$(echo .)ch \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox