From: plagnioj@jcrosoft•com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 02/11] fsmc/nand: Rearrange the fsmc_nand_data structure and update comments
Date: Tue, 9 Oct 2012 13:52:45 +0200 [thread overview]
Message-ID: <20121009115245.GL12801@game.jcrosoft.org> (raw)
In-Reply-To: <2aa2a9c00bcfa62605edfab8fb4c29448612ced3.1349778820.git.vipin.kumar@st.com>
On 16:14 Tue 09 Oct , Vipin Kumar wrote:
> Signed-off-by: Vipin Kumar <vipin.kumar@st•com>
> ---
> drivers/mtd/nand/fsmc_nand.c | 51 ++++++++++++++++++++++++++------------------
> 1 file changed, 30 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/mtd/nand/fsmc_nand.c b/drivers/mtd/nand/fsmc_nand.c
> index e96d7d1..bd89580 100644
> --- a/drivers/mtd/nand/fsmc_nand.c
> +++ b/drivers/mtd/nand/fsmc_nand.c
> @@ -278,52 +278,61 @@ static struct fsmc_eccplace fsmc_ecc4_sp_place = {
> * struct fsmc_nand_data - structure for FSMC NAND device state
> *
> * @pid: Part ID on the AMBA PrimeCell format
> - * @mtd: MTD info for a NAND flash.
> - * @nand: Chip related info for a NAND flash.
> - * @partitions: Partition info for a NAND Flash.
> - * @nr_partitions: Total number of partition of a NAND flash.
> - *
> - * @ecc_place: ECC placing locations in oobfree type format.
> - * @bank: Bank number for probed device.
> - * @clk: Clock structure for FSMC.
> + * @mtd: MTD info for a NAND flash
> + * @nand: Chip related info for a NAND flash
> + * @dev: Device structure pointer
> + * @clk: Clock structure for FSMC
> + * @ecc_place: ECC placing locations in oobfree type format
> + * @bank: Bank number for probed device
> *
> * @read_dma_chan: DMA channel for read access
> * @write_dma_chan: DMA channel for write access to NAND
> * @dma_access_complete: Completion structure
> *
> - * @data_pa: NAND Physical port for Data.
> - * @data_va: NAND port for Data.
> - * @cmd_va: NAND port for Command.
> - * @addr_va: NAND port for Address.
> - * @regs_va: FSMC regs base address.
> + * @dev_timings: Timings to be programmed in controller
> + * @partitions: Partition info for a NAND Flash
> + * @nr_partitions: Total number of partition of a NAND flash
> + * @mode: Defines the NAND device access mode
> + * Can be one of:
> + * - DMA access
> + * - Word access (CPU)
> + * - None (Use driver default ie bus width specific
> + * CPU access)
> + * @select_chip: Select a particular bank
> + *
> + * @data_pa: NAND Physical port for Data
> + * @data_va: NAND port for Data
> + * @cmd_va: NAND port for Command
> + * @addr_va: NAND port for Address
> + * @regs_va: FSMC regs base address
> */
> struct fsmc_nand_data {
> u32 pid;
> struct mtd_info mtd;
> struct nand_chip nand;
> - struct mtd_partition *partitions;
> - unsigned int nr_partitions;
> -
> - struct fsmc_eccplace *ecc_place;
> - unsigned int bank;
> struct device *dev;
> - enum access_mode mode;
> struct clk *clk;
> + struct fsmc_eccplace *ecc_place;
> + unsigned int bank;
>
> /* DMA related objects */
> struct dma_chan *read_dma_chan;
> struct dma_chan *write_dma_chan;
> struct completion dma_access_complete;
>
> + /* Recieved from plat data */
> struct fsmc_nand_timings *dev_timings;
> + struct mtd_partition *partitions;
> + unsigned int nr_partitions;
where do you use those execpt at probe time
> + enum access_mode mode;
> + void (*select_chip)(uint32_t bank, uint32_t busw);
>
> + /* Virtual/Physical addresses for CPU/DMA access */
> dma_addr_t data_pa;
> void __iomem *data_va;
> void __iomem *cmd_va;
> void __iomem *addr_va;
> void __iomem *regs_va;
> -
> - void (*select_chip)(uint32_t bank, uint32_t busw);
> };
>
> /* Assert CS signal based on chipnr */
> --
> 1.7.11.4
>
next prev parent reply other threads:[~2012-10-09 11:52 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 10:44 [PATCH 00/11] mtd/nand: fsmc driver updates Vipin Kumar
2012-10-09 10:44 ` [PATCH 01/11] fsmc/nand:FIX: Change the type for regs to void __iomem * Vipin Kumar
2012-10-09 17:14 ` viresh kumar
2012-10-10 16:49 ` Linus Walleij
2012-10-17 12:30 ` Artem Bityutskiy
2012-10-09 10:44 ` [PATCH 02/11] fsmc/nand: Rearrange the fsmc_nand_data structure and update comments Vipin Kumar
2012-10-09 11:52 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-10-11 4:24 ` Vipin Kumar
2012-10-09 17:15 ` viresh kumar
2012-10-09 10:44 ` [PATCH 03/11] fsmc/nand: Support multiple banks connected to controller Vipin Kumar
2012-10-09 11:55 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-10 10:28 ` Vipin Kumar
2012-10-17 12:31 ` Artem Bityutskiy
2012-10-09 10:44 ` [PATCH 04/11] fsmc/nand: Accept nand timing parameters via DT Vipin Kumar
2012-10-09 11:57 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-11 4:25 ` Vipin Kumar
2012-10-09 17:20 ` viresh kumar
2012-10-09 10:44 ` [PATCH 05/11] fsmc: Implement ready/busy through gpio pin Vipin Kumar
2012-10-09 11:59 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-09 17:34 ` viresh kumar
2012-10-09 10:44 ` [PATCH 06/11] fsmc/nand: Modify the wait to uninterruptible Vipin Kumar
2012-10-10 17:10 ` Linus Walleij
2012-10-17 12:47 ` Artem Bityutskiy
2012-10-09 10:44 ` [PATCH 07/11] fsmc/nand: Provide contiguous buffers to dma Vipin Kumar
2012-10-09 17:41 ` viresh kumar
2012-10-10 17:07 ` Linus Walleij
2012-10-11 3:16 ` viresh kumar
2012-10-11 4:07 ` Vipin Kumar
2012-10-11 4:08 ` Vipin Kumar
2012-10-11 4:15 ` viresh kumar
2012-10-11 16:06 ` Linus Walleij
2012-10-11 17:07 ` viresh kumar
2012-10-11 21:51 ` Linus Walleij
2012-10-12 3:55 ` Vipin Kumar
2012-10-15 13:18 ` Artem Bityutskiy
2012-10-15 16:27 ` Brian Norris
2012-10-15 19:51 ` Linus Walleij
2012-10-16 7:14 ` Artem Bityutskiy
2012-10-16 10:05 ` Linus Walleij
2012-10-21 7:38 ` Brian Norris
2012-10-21 11:00 ` Artem Bityutskiy
2012-10-21 12:02 ` Artem Bityutskiy
2012-10-16 7:11 ` Artem Bityutskiy
2012-10-21 7:21 ` Brian Norris
2012-10-09 10:44 ` [PATCH 08/11] fsmc/nand: Use relaxed variants of io accessors Vipin Kumar
2012-10-09 17:42 ` viresh kumar
2012-10-10 17:09 ` Linus Walleij
2012-10-09 10:44 ` [PATCH 09/11] fsmc/nand:FIX: replace change_bit routine Vipin Kumar
2012-10-10 17:22 ` Linus Walleij
2012-10-10 20:21 ` Nicolas Pitre
2012-10-11 4:17 ` Vipin Kumar
2012-10-10 20:45 ` Russell King - ARM Linux
2012-10-11 4:20 ` Vipin Kumar
2012-10-09 10:44 ` [PATCH 10/11] fsmc/nand: Add sw bch support for ecc calculation/correction Vipin Kumar
2012-10-09 11:50 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-10 10:33 ` Vipin Kumar
2012-10-09 10:44 ` [PATCH 11/11] nand: Increase the ecc placement locations to 640 Vipin Kumar
2012-10-17 12:47 ` Artem Bityutskiy
2012-10-18 6:36 ` Brian Norris
2012-10-17 12:48 ` [PATCH 00/11] mtd/nand: fsmc driver updates Artem Bityutskiy
2012-10-18 4:13 ` Vipin Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121009115245.GL12801@game.jcrosoft.org \
--to=plagnioj@jcrosoft$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox