From: olof@lixom•net (Olof Johansson)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 5/6] ARM: EXYNOS: Add support for Exynos secure firmware
Date: Wed, 10 Oct 2012 09:00:27 -0700 [thread overview]
Message-ID: <20121010160027.GA582@quad.lixom.net> (raw)
In-Reply-To: <1348496913-25422-6-git-send-email-t.figa@samsung.com>
Hi,
On Mon, Sep 24, 2012 at 04:28:32PM +0200, Tomasz Figa wrote:
> Some Exynos-based boards contain secure firmware and must use firmware
> operations to set up some hardware.
>
> This patch adds firmware operations for Exynos secure firmware and a way
> for board code and device tree to specify that they must be used.
>
> Example of use:
>
> In board code:
>
> ...MACHINE_START(...)
> /* ... */
> .init_early = exynos_firmware_init,
> /* ... */
> MACHINE_END
>
> In device tree:
>
> / {
> /* ... */
>
> firmware {
> compatible = "samsung,secure-firmware";
> };
>
> /* ... */
> };
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung•com>
> Signed-off-by: Tomasz Figa <t.figa@samsung•com>
> ---
> .../devicetree/bindings/arm/samsung-boards.txt | 8 ++++
> arch/arm/mach-exynos/Makefile | 1 +
> arch/arm/mach-exynos/common.h | 2 +
> arch/arm/mach-exynos/firmware.c | 54 ++++++++++++++++++++++
> arch/arm/mach-exynos/mach-exynos4-dt.c | 1 +
> 5 files changed, 66 insertions(+)
> create mode 100644 arch/arm/mach-exynos/firmware.c
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung-boards.txt b/Documentation/devicetree/bindings/arm/samsung-boards.txt
> index 0bf68be..f447059 100644
> --- a/Documentation/devicetree/bindings/arm/samsung-boards.txt
> +++ b/Documentation/devicetree/bindings/arm/samsung-boards.txt
> @@ -6,3 +6,11 @@ Required root node properties:
> - compatible = should be one or more of the following.
> (a) "samsung,smdkv310" - for Samsung's SMDKV310 eval board.
> (b) "samsung,exynos4210" - for boards based on Exynos4210 SoC.
> +
> +Optional:
> + - firmware node, specifying presence and type of secure firmware, currently
> + supported value of compatible property is "samsung,secure-firmware":
> +
> + firmware {
> + compatible = "samsung,secure-firmware";
> + };
If you require the binding to specify the memory area, then you at least allow
for future work to move to a dynamic mapping without updating the binding and
all device trees. So, please do that even if the code is hardcoded to the
static address today.
For extra credit, make sure that the reg property is matching the static mapping
when you setup your firmware interface on your platform.
[...]
> +static int exynos_cpu_boot_reg(int cpu, void __iomem **ptr)
> +{
> + *ptr = S5P_VA_SYSRAM_NS + 0x1c + 4*cpu;
> + return 0;
> +}
It would be nice to get a memory map for the SMC area in documentation
somewhere, but that can be done separately later.
-Olof
next prev parent reply other threads:[~2012-10-10 16:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 14:28 [PATCH v2 0/6] ARM: EXYNOS: Add secure firmware support Tomasz Figa
2012-09-24 14:28 ` [PATCH 1/6] ARM: Add interface for registering and calling firmware-specific operations Tomasz Figa
2012-09-24 14:28 ` [PATCH 2/6] ARM: EXYNOS: Add support for secure monitor calls Tomasz Figa
2012-09-24 14:28 ` [PATCH 3/6] ARM: EXYNOS: Add support for secondary CPU bring-up on Exynos4412 Tomasz Figa
2012-09-24 14:28 ` [PATCH 4/6] ARM: EXYNOS: Add IO mapping for non-secure SYSRAM Tomasz Figa
2012-09-24 14:28 ` [PATCH 5/6] ARM: EXYNOS: Add support for Exynos secure firmware Tomasz Figa
2012-10-10 16:00 ` Olof Johansson [this message]
2012-10-11 13:18 ` Tomasz Figa
2012-09-24 14:28 ` [PATCH 6/6] ARM: EXYNOS: Add secure firmware support to secondary CPU bring-up Tomasz Figa
2012-10-10 16:08 ` Olof Johansson
2012-10-02 9:13 ` [PATCH v2 0/6] ARM: EXYNOS: Add secure firmware support Tomasz Figa
2012-10-10 15:35 ` Kyungmin Park
2012-10-10 16:11 ` Olof Johansson
2012-10-11 13:19 ` Tomasz Figa
2012-10-15 13:59 ` Kukjin Kim
2012-10-10 16:09 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121010160027.GA582@quad.lixom.net \
--to=olof@lixom$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox