public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/4] leds: leds-ns2: add device tree binding
Date: Tue, 16 Oct 2012 13:02:39 +0000	[thread overview]
Message-ID: <201210161302.39302.arnd@arndb.de> (raw)
In-Reply-To: <1350315295-14567-2-git-send-email-simon.guinot@sequanux.org>

On Monday 15 October 2012, Simon Guinot wrote:
> diff --git a/Documentation/devicetree/bindings/gpio/leds-ns2.txt b/Documentation/devicetree/bindings/gpio/leds-ns2.txt
> new file mode 100644
> index 0000000..1a84969
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/leds-ns2.txt
> @@ -0,0 +1,26 @@
> +Binding for dual-GPIO LED found on Network Space v2 (and parents).
> +
> +Required properties:
> +- compatible: "ns2-leds".
> +
> +Each LED is represented as a sub-node of the ns2-leds device.
> +
> +Required sub-node properties:
> +- cmd-gpio: Command LED GPIO. See OF device-tree GPIO specification.
> +- slow-gpio: Slow LED GPIO. See OF device-tree GPIO specification.
> +
> +Optional sub-node properties:
> +- label: Name for this LED. If omitted, the label is taken from the node name.
> +- linux,default-trigger: Trigger assigned to the LED.

Hi Simon,

I'm not overly familiar with the LED subsystem, but isn't this something
that could be done with the generic gpio-led driver?

If not, is it possible to extend that driver in a way to make it possible
and remove the leds-ns2 driver?

	Arnd

  parent reply	other threads:[~2012-10-16 13:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-15 15:34 [PATCH 0/4] Add DT support for Network Space v2 and parents Simon Guinot
2012-10-15 15:34 ` [PATCH 1/4] leds: leds-ns2: add device tree binding Simon Guinot
2012-10-15 17:41   ` Jason Cooper
2012-10-15 19:12     ` Simon Guinot
2012-10-15 19:58       ` Jason Cooper
2012-10-16  9:39         ` Simon Guinot
2012-10-16 15:35           ` Jason Cooper
2012-10-16 13:02   ` Arnd Bergmann [this message]
2012-10-16 13:51     ` Simon Guinot
2012-10-16 18:56       ` Arnd Bergmann
2012-10-15 15:34 ` [PATCH 2/4] ARM: kirkwood: DT board setup for Network Space v2 and parents Simon Guinot
2012-10-15 19:36   ` Simon Guinot
2012-10-15 19:58   ` Rob Herring
2012-10-16 20:22     ` [PATCH] ARM: mach-kirkwood: add documentation for device tree bindings Simon Guinot
2012-10-16 20:41     ` [PATCH 2/4] ARM: kirkwood: DT board setup for Network Space v2 and parents Simon Guinot
2012-10-15 15:34 ` [PATCH 3/4] ARM: kirkwood: DT board setup for Network Space Lite v2 Simon Guinot
2012-10-15 15:34 ` [PATCH 4/4] ARM: kirkwood: DT board setup for Network Space Mini v2 Simon Guinot
2012-10-15 17:01 ` [PATCH 0/4] Add DT support for Network Space v2 and parents Jason Cooper
2012-10-15 18:50   ` Simon Guinot
2012-10-15 19:13     ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201210161302.39302.arnd@arndb.de \
    --to=arnd@arndb$(echo .)de \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox