From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] GPIO: mvebu-gpio: Don't initialize the mask_cache
Date: Sat, 27 Oct 2012 18:58:58 +0200 [thread overview]
Message-ID: <20121027165858.GC15824@lunn.ch> (raw)
In-Reply-To: <20121027185305.71d88c07@skate>
On Sat, Oct 27, 2012 at 06:53:05PM +0200, Thomas Petazzoni wrote:
>
> On Sat, 27 Oct 2012 18:31:41 +0200, Linus Walleij wrote:
> > On Sat, Oct 27, 2012 at 3:28 PM, Andrew Lunn <andrew@lunn•ch> wrote:
> >
> > > Due to the SMP nature of some of the chips, which have per CPU
> > > registers, the driver does not use the generic irq_gc_mask_set_bit() &
> > > irq_gc_mask_clr_bit() functions, which only support a single register.
> > > The driver has its own implementation of these functions, which can
> > > pick the correct register depending on the CPU being used. The
> > > functions do however use the gc->mask_cache value.
> > >
> > > The call to irq_setup_generic_chip() was passing
> > > IRQ_GC_INIT_MASK_CACHE, which caused the gc->mask_cache to be
> > > initialized to the contents of some random register. This resulted in
> > > unexpected interrupts been delivered from random GPIO lines.
> > >
> > > Signed-off-by: Andrew Lunn <andrew@lunn•ch>
> >
> > Thanks, patch applied to fixes. Unless Thomas screams...
>
> Acked-by-the-not-screaming: Thomas Petazzoni <thomas.petazzoni@free-electrons•com>
>
> Sounds good? :-)
https://lwn.net/Articles/503829
Its at least new...
Andrew
next prev parent reply other threads:[~2012-10-27 16:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-27 13:28 [PATCH] GPIO: mvebu-gpio: Don't initialize the mask_cache Andrew Lunn
2012-10-27 16:31 ` Linus Walleij
2012-10-27 16:53 ` Thomas Petazzoni
2012-10-27 16:58 ` Andrew Lunn [this message]
2012-10-28 12:17 ` Jamie Lentin
2012-10-28 16:33 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121027165858.GC15824@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox