From: olof@lixom•net (Olof Johansson)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] arm: mvebu: support for the PlatHome OpenBlocks AX3-4 board
Date: Mon, 5 Nov 2012 09:48:41 -0800 [thread overview]
Message-ID: <20121105174841.GA20194@quad.lixom.net> (raw)
In-Reply-To: <1351107203-31808-1-git-send-email-thomas.petazzoni@free-electrons.com>
On Wed, Oct 24, 2012 at 09:33:23PM +0200, Thomas Petazzoni wrote:
> + compatible = "plathome,openblocks-ax3-4", "marvell,armadaxp-mv78260", "marvell,armadaxp", "marvell,armada-370-xp";
[...]
> diff --git a/arch/arm/mach-mvebu/armada-370-xp.c b/arch/arm/mach-mvebu/armada-370-xp.c
> index 49d7915..68f1483 100644
> --- a/arch/arm/mach-mvebu/armada-370-xp.c
> +++ b/arch/arm/mach-mvebu/armada-370-xp.c
> @@ -49,6 +49,7 @@ static void __init armada_370_xp_dt_init(void)
> static const char * const armada_370_xp_dt_board_dt_compat[] = {
> "marvell,a370-db",
> "marvell,axp-db",
> + "plathome,openblocks-ax3-4",
> NULL,
> };
Hi,
One of the big benefits of device trees is to, in a perfect world, having to avoid
adding new C code for a new board. It seems like this compatible array should
contain one of the more generic compatible fields instead, and you should then
have each board dts specify that as a fallback. It looks like you already list
those in the board dts file, so you're good at that end.
Would that work?
Also, I can't tell for sure but it seems like the list of compatibles in the
board dts go from specific to generic, i.e. if "marvell,armadaxp" is less
generic than "marvell,armada-370-xp".
-Olof
prev parent reply other threads:[~2012-11-05 17:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 8:19 [PATCH] arm: mvebu: support for the PlatHome OpenBlocks AX3 board Thomas Petazzoni
2012-10-23 8:42 ` Andrew Lunn
2012-10-23 8:45 ` Thomas Petazzoni
2012-10-23 11:16 ` Jason Cooper
2012-10-24 8:58 ` Gregory CLEMENT
2012-10-24 14:15 ` Thomas Petazzoni
2012-10-24 15:06 ` Andrew Lunn
2012-10-24 15:20 ` Thomas Petazzoni
2012-10-24 15:31 ` Andrew Lunn
2012-10-24 15:35 ` Thomas Petazzoni
2012-11-26 9:18 ` Hector Oron
2012-11-26 9:25 ` Thomas Petazzoni
2012-11-27 13:00 ` Jason Cooper
2012-11-28 2:45 ` Mio Watanabe
2012-12-16 16:18 ` Hector Oron
2012-10-24 19:33 ` [PATCH v2] arm: mvebu: support for the PlatHome OpenBlocks AX3-4 board Thomas Petazzoni
2012-11-05 17:48 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121105174841.GA20194@quad.lixom.net \
--to=olof@lixom$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox