From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V6 3/6] arm: cache-l2x0: add support for Aurora L2 cache ctrl
Date: Thu, 8 Nov 2012 14:08:41 +0000 [thread overview]
Message-ID: <201211081408.41983.arnd@arndb.de> (raw)
In-Reply-To: <508666A6.9040701@free-electrons.com>
The newly introduced l2_wt_override should be in the same #ifdef
as the code using it, otherwise we get:
arch/arm/mm/cache-l2x0.c:37:12: warning: 'l2_wt_override' defined but not used
Signed-off-by: Arnd Bergmann <arnd@arndb•de>
---
On Tuesday 23 October 2012, Gregory CLEMENT wrote:
> @@ -33,6 +34,11 @@ static DEFINE_RAW_SPINLOCK(l2x0_lock);
> static u32 l2x0_way_mask; /* Bitmask of active ways */
> static u32 l2x0_size;
> static unsigned long sync_reg_offset = L2X0_CACHE_SYNC;
> +static int l2_wt_override;
> +
> +/* Aurora don't have the cache ID register available, so we have to
> + * pass it though the device tree */
> +static u32 cache_id_part_number_from_dt;
diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
index 92ee4a0..6911b8b 100644
--- a/arch/arm/mm/cache-l2x0.c
+++ b/arch/arm/mm/cache-l2x0.c
@@ -34,7 +34,6 @@ static DEFINE_RAW_SPINLOCK(l2x0_lock);
static u32 l2x0_way_mask; /* Bitmask of active ways */
static u32 l2x0_size;
static unsigned long sync_reg_offset = L2X0_CACHE_SYNC;
-static int l2_wt_override;
/* Aurora don't have the cache ID register available, so we have to
* pass it though the device tree */
@@ -424,6 +423,8 @@ void __init l2x0_init(void __iomem *base, u32 aux_val, u32 aux_mask)
}
#ifdef CONFIG_OF
+static int l2_wt_override;
+
/*
* Note that the end addresses passed to Linux primitives are
* noninclusive, while the hardware cache range operations use
next prev parent reply other threads:[~2012-11-08 14:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 16:02 [PATCH V5] Add support for Aurora L2 Cache Controller Gregory CLEMENT
2012-09-26 16:02 ` [PATCH V5 1/6] arm: cache-l2x0: make outer_cache_fns a field of l2x0_of_data Gregory CLEMENT
2012-09-26 16:14 ` Jason Cooper
2012-09-26 16:33 ` Gregory CLEMENT
2012-09-26 16:02 ` [PATCH V5 2/6] arm: cache-l2x0: add an optional register to save/restore Gregory CLEMENT
2012-09-26 16:02 ` [PATCH V5 3/6] arm: cache-l2x0: add support for Aurora L2 cache ctrl Gregory CLEMENT
2012-09-26 17:11 ` Catalin Marinas
2012-09-27 9:35 ` Gregory CLEMENT
2012-09-27 9:35 ` [PATCH V6 " Gregory CLEMENT
2012-10-23 9:01 ` Russell King - ARM Linux
2012-10-23 9:43 ` Gregory CLEMENT
2012-10-23 10:00 ` Russell King - ARM Linux
2012-10-23 10:23 ` Gregory CLEMENT
2012-11-04 22:32 ` Russell King - ARM Linux
2012-11-05 23:50 ` Gregory CLEMENT
2012-11-06 0:24 ` Russell King - ARM Linux
2012-11-06 0:59 ` Gregory CLEMENT
2012-11-08 14:08 ` Arnd Bergmann [this message]
2012-11-08 14:21 ` Russell King - ARM Linux
2012-11-08 14:42 ` Arnd Bergmann
2012-09-26 16:02 ` [PATCH V5 4/6] arm: mvebu: add L2 cache support Gregory CLEMENT
2012-09-29 23:20 ` Olof Johansson
2012-09-26 16:02 ` [PATCH V5 5/6] arm: mvebu: add Aurora L2 Cache Controller to the DT Gregory CLEMENT
2012-09-26 16:02 ` [PATCH V5 6/6] arm: l2x0: add aurora related properties to OF binding Gregory CLEMENT
2012-09-26 16:08 ` [PATCH V5] Add support for Aurora L2 Cache Controller Gregory CLEMENT
2012-09-26 16:24 ` Jason Cooper
2012-09-26 16:40 ` Gregory CLEMENT
2012-09-26 18:48 ` Jason Cooper
2012-09-27 7:31 ` Gregory CLEMENT
2012-09-30 23:55 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211081408.41983.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox