From: mturquette@ti•com (Mike Turquette)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] clk: move IM-PD1 clocks to drivers/clk
Date: Mon, 19 Nov 2012 12:02:38 -0800 [thread overview]
Message-ID: <20121119200238.21126.61661@nucleus> (raw)
In-Reply-To: <1353350711-29916-1-git-send-email-linus.walleij@linaro.org>
Quoting Linus Walleij (2012-11-19 10:45:11)
> diff --git a/drivers/clk/versatile/clk-impd1.c b/drivers/clk/versatile/clk-impd1.c
> new file mode 100644
> index 0000000..28ac702
> --- /dev/null
> +++ b/drivers/clk/versatile/clk-impd1.c
> @@ -0,0 +1,96 @@
What is rule on GPL headers these days? I notice that this file is
missing as well as some of the other C files in drivers/clk/versatile/.
I prefer to have GPL headers and also establishing a copyright owner,
but maybe I'm out of touch with some new way of doing things?
> +#include <linux/clk-provider.h>
> +#include <linux/clk.h>
> +#include <linux/clkdev.h>
> +#include <linux/err.h>
> +#include <linux/io.h>
> +#include <linux/platform_data/clk-integrator.h>
> +
<snip>
> diff --git a/drivers/clk/versatile/clk-integrator.c b/drivers/clk/versatile/clk-integrator.c
> index a505392..5aa6ab9 100644
> --- a/drivers/clk/versatile/clk-integrator.c
> +++ b/drivers/clk/versatile/clk-integrator.c
> @@ -1,8 +1,9 @@
Same here. I guess I didn't catch this the first time around.
Rest of the patch looks fine so once the header question is answered
I'll either take it or you can respin with the headers.
Regards,
Mike
next prev parent reply other threads:[~2012-11-19 20:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 18:45 [PATCH] clk: move IM-PD1 clocks to drivers/clk Linus Walleij
2012-11-19 20:02 ` Mike Turquette [this message]
2012-11-19 20:45 ` Arnd Bergmann
2012-11-20 18:49 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121119200238.21126.61661@nucleus \
--to=mturquette@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox