From: w@1wt•eu (Willy Tarreau)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: kirkwood: convert Guruplug to use the device tree
Date: Mon, 3 Dec 2012 00:48:27 +0100 [thread overview]
Message-ID: <20121202234827.GM30822@1wt.eu> (raw)
In-Reply-To: <20121202234110.GM12509@titan.lakedaemon.net>
On Sun, Dec 02, 2012 at 06:41:10PM -0500, Jason Cooper wrote:
> On Mon, Dec 03, 2012 at 12:22:26AM +0100, Willy Tarreau wrote:
> > Hi Jason,
> >
> > On Sun, Dec 02, 2012 at 06:09:26PM -0500, Jason Cooper wrote:
> > > Willy,
> > >
> > > Great first DT patch! A few comments below.
> > >
> > > On Sun, Dec 02, 2012 at 04:51:24PM +0100, Willy Tarreau wrote:
> > > > Add a device tree entry for the Guruplug board. This port was
> > > > based both on the work done on the dreamplug and the dockstar.
> > > >
> > > > It builds, boots and works on my Guruplug Server plus.
> > >
> > > iirc, the Guruplug Server Plus has an esata port. Since this is the
> > > hardware you have, lets make this patch specific to it. So, the Subject
> > > line should refer to "Guruplug Server Plus", and
> >
> > (...)
> >
> > Thank you for your review and clear comments, I'll update the patch
> > accordingly.
> >
> > Since there are already pending changes for the merge window, I'll
> > rather resend it after the merge window when the changes are already
> > done, what do you think ?
>
> Doesn't matter in this case, I'll handle any conflicts. Please resend
> when ready. You can just base off of v3.7-rc7, or v3.8 if it drops.
OK will do.
> btw - did you upgrade u-boot for DT?
I remember I upgraded it recently because of the incompatibility with
kernels >= 3.2 causing random hangs at boot, but I don't know if it
supports DT.
> You should just have to add
> CONFIG_OF_LIBFDT to include/configs/guruplug.h. Then,
>
> bootm <kern addr> <initrd addr> <dtb addr>
>
> Without an initrd,
>
> bootm <kern addr> - <dtb addr>
Interesting, I'll have to check (I've put it back into my bag right
now).
Thanks!
Willy
next prev parent reply other threads:[~2012-12-02 23:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-02 15:51 [PATCH] ARM: kirkwood: convert Guruplug to use the device tree Willy Tarreau
2012-12-02 23:09 ` Jason Cooper
2012-12-02 23:22 ` Willy Tarreau
2012-12-02 23:41 ` Jason Cooper
2012-12-02 23:48 ` Willy Tarreau [this message]
2012-12-03 0:09 ` Jason Cooper
2012-12-09 18:40 ` [PATCH v2] ARM: kirkwood: convert Guruplug Server Plus " Willy Tarreau
2012-12-09 22:02 ` Jason Cooper
2012-12-09 22:37 ` Willy Tarreau
2012-12-09 23:57 ` Jason Cooper
2013-01-07 17:48 ` Jason Cooper
2013-01-07 18:08 ` Willy Tarreau
2013-01-07 18:17 ` Jason Cooper
2013-01-07 18:20 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121202234827.GM30822@1wt.eu \
--to=w@1wt$(echo .)eu \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox