From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: bcm281xx: Add timer driver
Date: Wed, 5 Dec 2012 15:50:44 +0000 [thread overview]
Message-ID: <201212051550.44288.arnd@arndb.de> (raw)
In-Reply-To: <50BF0DAE.6000202@broadcom.com>
On Wednesday 05 December 2012, Christian Daudt wrote:
> On 12-12-04 06:54 PM, Stephen Warren wrote:
> > On 12/03/2012 08:55 PM, Christian Daudt wrote:
> > I'm slightly worried about "kona". Is it a well-known name outside
> > Broadcom for this HW block? If it really is the name though, it's fine I
> > guess, since it's within the "bcm," name-space here.
> Some of these konas slip by :) This is an internal name, but I don't
> need to use it here. I'll change this to "bcm,bcm-timer"
bcm-timer sounds a bit too generic, unless it's the only one used in
Broadcom, I don't mind a code name like "kona" if that serves to
uniquely identify this timer implementation.
If you don't want to to use that, you should pick a specific mode number
and encode that into the compatible string, such as "bcm,bcm28154-timer".
You can then use the same string for every SoC whose timer is the
same as the one in the bcm28154.
> >> diff --git a/drivers/clocksource/bcm_timer.c b/drivers/clocksource/bcm_timer.c
> > Is this timer HW used in every Broadcom chip? I wonder if the file
> > shouldn't be named bcm_kona_timer.c to allow co-existence with any others.
>
> I'm sure it is not used in every Broadcom chip, but it is used in the
> ones I'm upstreaming at this point. I can always rename it if it turns
> out that this is no longer the only one, can't I ? I have been
> struggling a bit with when to use just "bcm" for name, and when to use
> something else. Internally we've used kona (and a number of other
> internal only names) but I've been trying to scrub these out of the code
> going to upstream, as the internal names are meaningless. But then I end
> up with no name in some cases, and I don't know that that is more
> helpful than the meaningless name...
If the name means something to you and is not likely to be used elsewhere in
broadcom for something different, then it's a good enough name. Leaving
out the name is not enough.
Arnd
prev parent reply other threads:[~2012-12-05 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 3:55 [PATCH] ARM: bcm281xx: Add timer driver Christian Daudt
2012-12-04 14:12 ` Arnd Bergmann
2012-12-05 2:54 ` Stephen Warren
2012-12-05 9:02 ` Christian Daudt
2012-12-05 15:50 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201212051550.44288.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox