public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: plagnioj@jcrosoft•com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists•infradead.org
Subject: [v2 PATCH 13/14] ARM: dts: add spi nodes for atmel SoC
Date: Fri, 7 Dec 2012 07:56:45 +0100	[thread overview]
Message-ID: <20121207065645.GG4398@game.jcrosoft.org> (raw)
In-Reply-To: <50C0C9C9.9000108@atmel.com>

On 17:37 Thu 06 Dec     , ludovic.desroches wrote:
> Hi,
> 
> On 12/04/2012 08:53 AM, Wenyou Yang wrote:
> >From: Richard Genoud <richard.genoud@gmail•com>
> >
> >Signed-off-by: Richard Genoud <richard.genoud@gmail•com>
> >[wenyou.yang at atmel.com: add spi nodes for other atmel SOC]
> >Signed-off-by: Wenyou Yang <wenyou.yang@atmel•com>
> >Cc: linux at arm.linux.org.uk
> >---
> >  arch/arm/boot/dts/at91sam9260.dtsi |   30 ++++++++++++++++++++++++++++++
> >  arch/arm/boot/dts/at91sam9263.dtsi |   30 ++++++++++++++++++++++++++++++
> >  arch/arm/boot/dts/at91sam9g45.dtsi |   30 ++++++++++++++++++++++++++++++
> >  arch/arm/boot/dts/at91sam9n12.dtsi |   30 ++++++++++++++++++++++++++++++
> >  arch/arm/boot/dts/at91sam9x5.dtsi  |   30 ++++++++++++++++++++++++++++++
> >  5 files changed, 150 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
> >index d410581..87254aa 100644
> >--- a/arch/arm/boot/dts/at91sam9260.dtsi
> >+++ b/arch/arm/boot/dts/at91sam9260.dtsi
> >@@ -212,6 +212,36 @@
> >  				status = "disabled";
> >  			};
> >
> >+			spi0: spi at fffc8000 {
> >+				#address-cells = <1>;
> >+				#size-cells = <0>;
> >+				compatible = "atmel,at91sam9260-spi";
> >+				reg = <0xfffc8000 0x200>;
> >+				interrupts = <12 4 3>;
> >+				cs-gpios = <&pioA 3 0
> >+					    &pioC 11 0
> >+					    &pioC 16 0
> >+					    &pioC 17 0
> >+					   >;
> 
> From my point of view, the cs-gpios stuff should be in board dts
> files instead of the SoC dtsi file.
> 
> These pios can be shared with other devices. If only one chip select
> gpio is used on the board, it could avoid some useless pin
> conflicts.
agree and you MUST based on work on what I send on the ML and Grant applyed

Best Regards,
J.
> 
> Regards
> 
> Ludovic
> 
> >+				dma-mask = <0xffffffff>;
> >+				status = "disabled";
> >+			};
> >+
> >+			spi1: spi at fffcc000 {
> >+				#address-cells = <1>;
> >+				#size-cells = <0>;
> >+				compatible = "atmel,at91sam9260-spi";
> >+				reg = <0xfffcc000 0x200>;
> >+				interrupts = <13 4 3>;
> >+				cs-gpios = <&pioB 3 0
> >+					    &pioC 5 0
> >+					    &pioC 4 0
> >+					    &pioC 3 0
> >+					   >;
> >+				dma-mask = <0xffffffff>;
> >+				status = "disabled";
> >+			};
> >+
> >  			adc0: adc at fffe0000 {
> >  				compatible = "atmel,at91sam9260-adc";
> >  				reg = <0xfffe0000 0x100>;
> >diff --git a/arch/arm/boot/dts/at91sam9263.dtsi b/arch/arm/boot/dts/at91sam9263.dtsi
> >index 3e6e5c1..528395d 100644
> >--- a/arch/arm/boot/dts/at91sam9263.dtsi
> >+++ b/arch/arm/boot/dts/at91sam9263.dtsi
> >@@ -195,6 +195,36 @@
> >  				#size-cells = <0>;
> >  				status = "disabled";
> >  			};
> >+
> >+			spi0: spi at fffa4000 {
> >+				#address-cells = <1>;
> >+				#size-cells = <0>;
> >+				compatible = "atmel,at91sam9260-spi";
> >+				reg = <0xfffa4000 0x200>;
> >+				interrupts = <14 4 3>;
> >+				cs-gpios = <&pioA 5 0
> >+					    &pioA 3 0
> >+					    &pioA 4 0
> >+					    &pioB 11 0
> >+					   >;
> >+				dma-mask = <0xffffffff>;
> >+				status = "disabled";
> >+			};
> >+
> >+			spi1: spi at fffa8000 {
> >+				#address-cells = <1>;
> >+				#size-cells = <0>;
> >+				compatible = "atmel,at91sam9260-spi";
> >+				reg = <0xfffa8000 0x200>;
> >+				interrupts = <15 4 3>;
> >+				cs-gpios = <&pioB 15 0
> >+					    &pioB 16 0
> >+					    &pioB 17 0
> >+					    &pioB 18 0
> >+					   >;
> >+				dma-mask = <0xffffffff>;
> >+				status = "disabled";
> >+			};
> >  		};
> >
> >  		nand0: nand at 40000000 {
> >diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi
> >index 3add030..8a6aae92 100644
> >--- a/arch/arm/boot/dts/at91sam9g45.dtsi
> >+++ b/arch/arm/boot/dts/at91sam9g45.dtsi
> >@@ -262,6 +262,36 @@
> >  					trigger-value = <0x6>;
> >  				};
> >  			};
> >+
> >+			spi0: spi at fffa4000 {
> >+				#address-cells = <1>;
> >+				#size-cells = <0>;
> >+				compatible = "atmel,at91sam9260-spi";
> >+				reg = <0xfffa4000 0x200>;
> >+				interrupts = <14 4 3>;
> >+				cs-gpios = <&pioB 3 0
> >+					    &pioB 18 0
> >+					    &pioB 19 0
> >+					    &pioD 27 0
> >+					   >;
> >+				dma-mask = <0xffffffff>;
> >+				status = "disabled";
> >+			};
> >+
> >+			spi1: spi at fffa8000 {
> >+				#address-cells = <1>;
> >+				#size-cells = <0>;
> >+				compatible = "atmel,at91sam9260-spi";
> >+				reg = <0xfffa8000 0x200>;
> >+				interrupts = <15 4 3>;
> >+				cs-gpios = <&pioB 17 0
> >+					    &pioD 28 0
> >+					    &pioD 18 0
> >+					    &pioD 19 0
> >+					   >;
> >+				dma-mask = <0xffffffff>;
> >+				status = "disabled";
> >+			};
> >  		};
> >
> >  		nand0: nand at 40000000 {
> >diff --git a/arch/arm/boot/dts/at91sam9n12.dtsi b/arch/arm/boot/dts/at91sam9n12.dtsi
> >index 82508d6..183cacf 100644
> >--- a/arch/arm/boot/dts/at91sam9n12.dtsi
> >+++ b/arch/arm/boot/dts/at91sam9n12.dtsi
> >@@ -202,6 +202,36 @@
> >  				#size-cells = <0>;
> >  				status = "disabled";
> >  			};
> >+
> >+			spi0: spi at f0000000 {
> >+				#address-cells = <1>;
> >+				#size-cells = <0>;
> >+				compatible = "atmel,at91sam9x5-spi";
> >+				reg = <0xf0000000 0x100>;
> >+				interrupts = <13 4 3>;
> >+				cs-gpios = <&pioA 14 0
> >+					    &pioA 7 0
> >+					    &pioA 1 0
> >+					    &pioB 3 0
> >+					   >;
> >+				dma-mask = <0xffffffff>;
> >+				status = "disabled";
> >+			};
> >+
> >+			spi1: spi at f0004000 {
> >+				#address-cells = <1>;
> >+				#size-cells = <0>;
> >+				compatible = "atmel,at91sam9x5-spi";
> >+				reg = <0xf0004000 0x100>;
> >+				interrupts = <14 4 3>;
> >+				cs-gpios = <&pioA 8 0
> >+					    &pioA 0 0
> >+					    &pioA 31 0
> >+					    &pioA 30 0
> >+					   >;
> >+				dma-mask = <0xffffffff>;
> >+				status = "disabled";
> >+			};
> >  		};
> >
> >  		nand0: nand at 40000000 {
> >diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
> >index 03fc136..95b55fd 100644
> >--- a/arch/arm/boot/dts/at91sam9x5.dtsi
> >+++ b/arch/arm/boot/dts/at91sam9x5.dtsi
> >@@ -263,6 +263,36 @@
> >  					trigger-value = <0x6>;
> >  				};
> >  			};
> >+
> >+			spi0: spi at f0000000 {
> >+				#address-cells = <1>;
> >+				#size-cells = <0>;
> >+				compatible = "atmel,at91sam9x5-spi";
> >+				reg = <0xf0000000 0x100>;
> >+				interrupts = <13 4 3>;
> >+				cs-gpios = <&pioA 14 0
> >+					    &pioA 7 0 /* conflicts with TXD2 */
> >+					    &pioA 1 0 /* conflicts with RXD0 */
> >+					    &pioB 3 0 /* conflicts with ERXDV */
> >+					   >;
> >+				dma-mask = <0xffffffff>;
> >+				status = "disabled";
> >+			};
> >+
> >+			spi1: spi at f0004000 {
> >+				#address-cells = <1>;
> >+				#size-cells = <0>;
> >+				compatible = "atmel,at91sam9x5-spi";
> >+				reg = <0xf0004000 0x100>;
> >+				interrupts = <14 4 3>;
> >+				cs-gpios = <&pioA 8 0 /* conflitcs with RXD2 */
> >+					    &pioA 0 0 /* conflitcs with TXD0 */
> >+					    &pioA 31 0 /* conflitcs with TWCK0 */
> >+					    &pioA 30 0 /* conflitcs with TWD0 */
> >+					   >;
> >+				dma-mask = <0xffffffff>;
> >+				status = "disabled";
> >+			};
> >  		};
> >
> >  		nand0: nand at 40000000 {
> >
> 

  parent reply	other threads:[~2012-12-07  6:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-04  7:53 [v2 PATCH 00/14] atmel SPI controller with dmaengine and device tree support Wenyou Yang
2012-12-04  7:53 ` [v2 PATCH 01/14] of: add dma-mask binding Wenyou Yang
2012-12-04 13:16   ` Rob Herring
2012-12-04  7:53 ` [v2 PATCH 02/14] of_spi: add generic binding support to specify cs gpio Wenyou Yang
2012-12-05 23:28   ` Grant Likely
2012-12-04  7:53 ` [v2 PATCH 03/14] spi/atmel_spi: add physical base address Wenyou Yang
2012-12-04  7:53 ` [v2 PATCH 04/14] spi/atmel_spi: call unmapping on transfers buffers Wenyou Yang
2012-12-04  7:53 ` [v2 PATCH 05/14] spi/atmel_spi: status information passed through controller data Wenyou Yang
2012-12-04  7:53 ` [v2 PATCH 06/14] spi/atmel_spi: add flag to controller data for lock operations Wenyou Yang
2012-12-04  7:53 ` [v2 PATCH 07/14] spi/atmel_spi: add DT support Wenyou Yang
2012-12-07  6:58   ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-04  7:53 ` [v2 PATCH 08/14] spi/atmel_spi: add dmaengine support Wenyou Yang
2012-12-04  7:53 ` [v2 PATCH 09/14] spi/atmel_spi: Fix spi-atmel driver to adapt to slave_config changes Wenyou Yang
2012-12-04  7:53 ` [v2 PATCH 10/14] spi/atmel_spi: correct 16 bits transfers using PIO Wenyou Yang
2012-12-04  7:53 ` [v2 PATCH 11/14] spi/atmel_spi: correct 16 bits transfer with DMA Wenyou Yang
2012-12-04  7:53 ` [v2 PATCH 12/14] ARM: at91: add clocks for spi DT entries Wenyou Yang
2012-12-04  7:53 ` [v2 PATCH 13/14] ARM: dts: add spi nodes for atmel SoC Wenyou Yang
2012-12-06 16:37   ` ludovic.desroches
2012-12-07  1:34     ` Yang, Wenyou
2012-12-07  6:56     ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-12-04  7:54 ` [v2 PATCH 14/14] ARM: dts: add spi nodes for atmel boards Wenyou Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121207065645.GG4398@game.jcrosoft.org \
    --to=plagnioj@jcrosoft$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox