From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/3] ARM: Orion: Bind the orion bridge interrupt controller through DT
Date: Tue, 11 Dec 2012 08:13:33 +0100 [thread overview]
Message-ID: <20121211071333.GR17242@lunn.ch> (raw)
In-Reply-To: <20121211065813.GA14843@obsidianresearch.com>
On Mon, Dec 10, 2012 at 11:58:13PM -0700, Jason Gunthorpe wrote:
> > > + bridge_irq = irq_of_parse_and_map(np, 0);
> > > + /* FIXME: irq_of_parse_and_map returns 0 on error, but on Dove the
> > > + * bridge IRQ is 0.
> > > + if (!bridge_irq)
> > > + return -ENODEV;*/
> > > +
> > > + return orion_bridge_irq_init(bridge_irq, -1, base, np);
> >
> > So does this mean for Dove it will currently always fail?
>
> I guess that is hard to read without syntax hi-lighting, the 'if' is
> also commented out.
>
> I was hopefull it would work as is, but looking deeper at
> irq_of_parse_and_map and its call tree makes me doubtfull now..
>
> Fixing irq_of_parse_and_map is way to big a job for me :(
Hi Jason
https://lwn.net/Articles/470820/
I don't think its fixable.
> What to do from here? Add a dummy 0 interrupt to dove? Take dove out
> of this patch series?
We need to see how other machine remap 0 to some other value and
implement that for Dove.
Andrew
next prev parent reply other threads:[~2012-12-11 7:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 1:18 [PATCHv2 1/3] ARM: Orion: Hoist bridge interrupt handling out of the timer Jason Gunthorpe
2012-12-11 1:18 ` [PATCH 2/3] ARM: Orion: Bind the orion bridge interrupt controller through DT Jason Gunthorpe
2012-12-11 6:24 ` Andrew Lunn
2012-12-11 6:58 ` Jason Gunthorpe
2012-12-11 7:13 ` Andrew Lunn [this message]
2012-12-11 18:55 ` Jason Gunthorpe
2013-01-10 1:47 ` Jason Cooper
2013-01-10 6:07 ` Andrew Lunn
2013-01-10 9:54 ` Sebastian Hesselbarth
2013-01-10 18:48 ` Jason Gunthorpe
2013-01-10 18:57 ` Jason Cooper
2013-01-11 4:02 ` Jason Gunthorpe
2013-01-11 8:13 ` Thomas Petazzoni
2013-01-11 11:59 ` Jason Cooper
2012-12-11 1:18 ` [PATCH 3/3] ARM: Orion: Bind the orion timer " Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121211071333.GR17242@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox