From: gregkh@linuxfoundation•org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] drivers/pinctrl: grab default handles from device core
Date: Tue, 11 Dec 2012 10:13:36 -0800 [thread overview]
Message-ID: <20121211181336.GD25714@kroah.com> (raw)
In-Reply-To: <1355233246-16694-1-git-send-email-linus.walleij@stericsson.com>
On Tue, Dec 11, 2012 at 02:40:46PM +0100, Linus Walleij wrote:
> diff --git a/include/linux/device.h b/include/linux/device.h
> index 86ef6ab..dc399ab 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -21,6 +21,7 @@
> #include <linux/compiler.h>
> #include <linux/types.h>
> #include <linux/mutex.h>
> +#include <linux/pinctrl/devinfo.h>
> #include <linux/pm.h>
> #include <linux/atomic.h>
> #include <linux/ratelimit.h>
> @@ -605,6 +606,8 @@ struct device_dma_parameters {
> * @pm_domain: Provide callbacks that are executed during system suspend,
> * hibernation, system resume and during runtime PM transitions
> * along with subsystem-level and driver-level callbacks.
> + * @pins: For device pin management.
> + * See Documentation/pinctrl.txt for details.
> * @numa_node: NUMA node this device is close to.
> * @dma_mask: Dma mask (if dma'ble device).
> * @coherent_dma_mask: Like dma_mask, but for alloc_coherent mapping as not all
> @@ -656,6 +659,10 @@ struct device {
> struct dev_pm_info power;
> struct dev_pm_domain *pm_domain;
>
> +#ifdef CONFIG_PINCTRL
> + struct dev_pin_info pins;
> +#endif
Can't you just make this a * to the structure, saving a bit of space for
those that don't use this structure? Ok, it's only saving one pointer,
so it's really not a big deal to me if you don't want to do this, just
asking...
Also, this will have to wait until after 3.8-rc1 before I can consider
merging it, I'm a bit busy for the next two weeks at the least...
thanks,
greg k-h
next prev parent reply other threads:[~2012-12-11 18:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 13:40 [PATCH] drivers/pinctrl: grab default handles from device core Linus Walleij
2012-12-11 18:13 ` Greg Kroah-Hartman [this message]
2012-12-12 11:58 ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-12 19:58 ` Linus Walleij
2012-12-12 19:56 ` Linus Walleij
2012-12-12 22:26 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121211181336.GD25714@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox