From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 12/18] arm: kirkwood: dreamplug: use Device Tree to probe SDIO
Date: Tue, 18 Dec 2012 17:28:04 +0100 [thread overview]
Message-ID: <20121218162804.GJ3392@lunn.ch> (raw)
In-Reply-To: <1355841243-3254-13-git-send-email-thomas.petazzoni@free-electrons.com>
On Tue, Dec 18, 2012 at 03:33:57PM +0100, Thomas Petazzoni wrote:
> Now that the mvsdio driver has a Device Tree binding, and the SDIO
> controller is declared in kirkwood.dtsi, migrate the dreamplug board
> to use the Device Tree to probe the SDIO controller.
Hi Thomas
It would be nice to add pinctrl to this. The likely pins are defined
in kirkwood-6281.dtsi. dreamplug does not define hogs for these pins,
so its relying on grub setting them up and nothing changing them.
Maybe Jason can do this?
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons•com>
> Cc: Jason Cooper <jason@lakedaemon•net>
> ---
> arch/arm/boot/dts/kirkwood-dreamplug.dts | 5 +++++
> arch/arm/mach-kirkwood/board-dreamplug.c | 5 -----
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/kirkwood-dreamplug.dts b/arch/arm/boot/dts/kirkwood-dreamplug.dts
> index f2d386c..0fceb76 100644
> --- a/arch/arm/boot/dts/kirkwood-dreamplug.dts
> +++ b/arch/arm/boot/dts/kirkwood-dreamplug.dts
> @@ -74,6 +74,11 @@
> status = "okay";
> nr-ports = <1>;
> };
> +
> + mvsdio at 90000 {
> + status = "okay";
> + /* No CD or WP GPIOs */
> + };
> };
>
> gpio-leds {
> diff --git a/arch/arm/mach-kirkwood/board-dreamplug.c b/arch/arm/mach-kirkwood/board-dreamplug.c
> index 08248e2..b712b7f 100644
> --- a/arch/arm/mach-kirkwood/board-dreamplug.c
> +++ b/arch/arm/mach-kirkwood/board-dreamplug.c
There is probably a header file which can be removed as well.
Thanks
Andrew
> @@ -26,10 +26,6 @@ static struct mv643xx_eth_platform_data dreamplug_ge01_data = {
> .phy_addr = MV643XX_ETH_PHY_ADDR(1),
> };
>
> -static struct mvsdio_platform_data dreamplug_mvsdio_data = {
> - /* unfortunately the CD signal has not been connected */
> -};
> -
> void __init dreamplug_init(void)
> {
> /*
> @@ -37,5 +33,4 @@ void __init dreamplug_init(void)
> */
> kirkwood_ge00_init(&dreamplug_ge00_data);
> kirkwood_ge01_init(&dreamplug_ge01_data);
> - kirkwood_sdio_init(&dreamplug_mvsdio_data);
> }
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2012-12-18 16:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 14:33 Device Tree binding for the mvsdio driver and related changes Thomas Petazzoni
2012-12-18 14:33 ` [PATCH 01/18] mmc: mvsdio: use slot-gpio infrastructure for write protect gpio Thomas Petazzoni
2012-12-18 14:33 ` [PATCH 02/18] mmc: mvsdio: use slot-gpio for card detect gpio Thomas Petazzoni
2012-12-18 14:33 ` [PATCH 03/18] mmc: mvsdio: implement a Device Tree binding Thomas Petazzoni
2012-12-18 14:33 ` [PATCH 04/18] mmc: mvsdio: add pinctrl integration Thomas Petazzoni
2012-12-18 14:33 ` [PATCH 05/18] arm: mvebu: add DT information for the SDIO interface of Armada 370/XP Thomas Petazzoni
2012-12-18 14:33 ` [PATCH 06/18] arm: mvebu: add pin muxing options for the SDIO interface on Armada 370 Thomas Petazzoni
2012-12-18 14:33 ` [PATCH 07/18] arm: mvebu: add pin muxing options for the SDIO interface on Armada XP Thomas Petazzoni
2012-12-18 14:33 ` [PATCH 08/18] arm: mvebu: enable the SD card slot on Armada XP DB board Thomas Petazzoni
2012-12-18 14:33 ` [PATCH 09/18] arm: mvebu: enable the SD card slot on Armada 370 " Thomas Petazzoni
2012-12-18 14:33 ` [PATCH 10/18] arm: mvebu: enable the SDIO interface on the Globalscale Mirabox Thomas Petazzoni
2012-12-18 14:33 ` [PATCH 11/18] arm: kirkwood: add Device Tree informations for the SDIO controller Thomas Petazzoni
2012-12-18 14:33 ` [PATCH 12/18] arm: kirkwood: dreamplug: use Device Tree to probe SDIO Thomas Petazzoni
2012-12-18 16:28 ` Andrew Lunn [this message]
2012-12-18 14:33 ` [PATCH 13/18] arm: kirkwood: mplcec4: " Thomas Petazzoni
2012-12-18 16:31 ` Andrew Lunn
2012-12-18 14:33 ` [PATCH 14/18] arm: kirkwood: topkick: " Thomas Petazzoni
2012-12-18 14:34 ` [PATCH 15/18] arm: kirkwood: dockstar: remove useless include of SDIO header Thomas Petazzoni
2012-12-18 14:34 ` [PATCH 16/18] arm: mvebu: enable SDIO support in mvebu_defconfig Thomas Petazzoni
2012-12-18 14:34 ` [PATCH 17/18] arm: mvebu: enable mwifiex driver " Thomas Petazzoni
2012-12-18 16:35 ` Andrew Lunn
2012-12-18 14:34 ` [PATCH 18/18] arm: mvebu: enable btmrvl " Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121218162804.GJ3392@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox