From: ben@decadent•org.uk (Ben Hutchings)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/4] FEC: Add time stamping code and a PTP hardware clock
Date: Wed, 19 Dec 2012 15:53:20 +0000 [thread overview]
Message-ID: <20121219155319.GP13292@decadent.org.uk> (raw)
In-Reply-To: <20121218070420.GA2946@netboy.at.omicron.at>
On Tue, Dec 18, 2012 at 08:04:20AM +0100, Richard Cochran wrote:
> On Mon, Dec 17, 2012 at 09:02:32PM +0100, Sascha Hauer wrote:
> > This leaves an option in the tree which can be used to break FEC on
> > i.MX3/5.
> >
> > depends on !SOC_IMX31 && !SOC_IMX35 && !SOC_IMX5
> >
> > might be an option, but given that this patch seems to have bypassed any
> > review I feel more like reverting it.
>
> Instead of reverting, I suggest finding a solution (Frank) to let the
> code work when it can work and to prevent it when it cannot. This
> could be kconfig, DT, or run time probing of silicon revisions, but I
> don't have access to this hardware, and so I can't really say how to
> fix it.
[...]
Please implement run-time probing. A different configuration for
each SoC is just not sustainable for distributions.
Ben.
--
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
- Albert Camus
prev parent reply other threads:[~2012-12-19 15:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 4:25 [PATCH 4/4] FEC: Add time stamping code and a PTP hardware clock Frank Li
2012-11-02 9:19 ` Richard Cochran
2012-11-06 1:36 ` Frank Li
2012-12-17 9:13 ` Sascha Hauer
2012-12-17 14:48 ` Frank Li
2012-12-17 15:14 ` Shawn Guo
2012-12-17 20:02 ` Sascha Hauer
2012-12-18 7:04 ` Richard Cochran
2012-12-18 8:51 ` Frank Li
2012-12-19 15:53 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121219155319.GP13292@decadent.org.uk \
--to=ben@decadent$(echo .)org.uk \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox