From: marex@denx•de (Marek Vasut)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 3/7] usb: chipidea: add otg id switch and vbus connect/disconnect detect
Date: Thu, 27 Dec 2012 09:31:11 +0100 [thread overview]
Message-ID: <201212270931.12026.marex@denx.de> (raw)
In-Reply-To: <20121227082007.GA29123@nchen-desktop>
Dear Peter Chen,
> On Thu, Dec 27, 2012 at 08:21:55AM +0100, Marek Vasut wrote:
> > Dear Peter Chen,
> >
> > [...]
> >
> > > +
> > > +#define CI_VBUS_STABLE_TIMEOUT 500
> >
> > Shall we not change this to static const int instead ?
>
> Is it a must?
> I find the similar at drivers/usb/core/hub.c
[...]
No it's not. I was just pondering now that it's a local constant, it might just
be like that.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-12-27 8:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-27 6:59 [PATCH v4 0/7] Add fully tested id switch and vbus connect detect support for Chipidea Peter Chen
2012-12-27 6:59 ` [PATCH v4 1/7] Revert "USB: chipidea: add vbus detect for udc" Peter Chen
2012-12-27 6:59 ` [PATCH v4 2/7] usb: chipidea: add otg file Peter Chen
2012-12-27 10:47 ` Sascha Hauer
2012-12-28 2:14 ` Peter Chen
2012-12-27 6:59 ` [PATCH v4 3/7] usb: chipidea: add otg id switch and vbus connect/disconnect detect Peter Chen
2012-12-27 7:21 ` Marek Vasut
2012-12-27 8:20 ` Peter Chen
2012-12-27 8:31 ` Marek Vasut [this message]
2012-12-27 7:00 ` [PATCH v4 4/7] usb: chipidea: consolidate ci_role_driver's API for both roles Peter Chen
2012-12-27 7:00 ` [PATCH v4 5/7] usb: chipidea: udc: add pullup/pulldown dp at hw_device_state Peter Chen
2012-12-27 7:00 ` [PATCH v4 6/7] usb: chipidea: udc: retire the flag CI13_PULLUP_ON_VBUS Peter Chen
2012-12-27 7:00 ` [PATCH v4 7/7] usb: chipidea: imx: add internal vbus regulator control Peter Chen
2013-01-08 15:27 ` [PATCH v4 0/7] Add fully tested id switch and vbus connect detect support for Chipidea Maxime Ripard
2013-01-09 3:23 ` Peter Chen
2013-01-09 11:43 ` Maxime Ripard
2013-01-10 1:38 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201212270931.12026.marex@denx.de \
--to=marex@denx$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox