From: heiko@sntech•de (Heiko Stübner)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 00/11] ARM: S3C24XX: rework irq handling for a later dt usage
Date: Thu, 3 Jan 2013 01:48:34 +0100 [thread overview]
Message-ID: <201301030148.35569.heiko@sntech.de> (raw)
In-Reply-To: <042901cde941$bb8d2d30$32a78790$@samsung.com>
Am Donnerstag, 3. Januar 2013, 00:34:36 schrieb Kukjin Kim:
> Heiko St?bner wrote:
> > Second version of redoing the s3c24xx irqs in a generic way by using a
> > declarative approach.
> >
> > Changes include further generalizations resulting only in common
> > irq-type declarations being needed and thus again easier code.
> >
> > As in the first version, the 1st patch might be hard to read due to the
> > rewrite character, but I didn't see a way to do these changes in
> > individual steps. So it might be helpful to look at the result after
> > applying this patch.
> >
> > Runtime-tested on a s3c2416 based board and compile tested for the
> > others.
> >
> > As also written before, inclusion of the other S3C24XX SoCs to follow
> > once the general approach is acceptable.
> >
> > Heiko Stuebner (11):
> > ARM: S3C24XX: transform irq handling into a declarative form
> > ARM: S3C24XX: move irq-pm code into main irq file
> > ARM: S3C24XX: cleanup irq-pm integration
> > ARM: S3C24XX: move s3c2416 irq init to common irq code
> > ARM: S3C24XX: modify s3c2416 irq init to initialize all irqs
> > ARM: S3C24XX: assimilate s3c2416 subirqs into new structure
> > ARM: S3C24XX: assimilate second s3c2416 interrupt into new structure
> > ARM: S3C24XX: move s3c2443 irq code to irq.c
> > ARM: S3C24XX: modify s3c2443 irq init to initialize all irqs
> > ARM: S3C24XX: assimilate s3c2443 subirqs into new structure
> > ARM: S3C24XX: remove maskack irq ack funtions
> >
> > arch/arm/mach-s3c24xx/Makefile | 6 +-
> > arch/arm/mach-s3c24xx/common.h | 2 +
> > arch/arm/mach-s3c24xx/irq-pm.c | 95 ---
> > arch/arm/mach-s3c24xx/irq-s3c2416.c | 348 --------
> > arch/arm/mach-s3c24xx/irq-s3c2443.c | 281 -------
> > arch/arm/mach-s3c24xx/mach-smdk2416.c | 2 +-
> > arch/arm/mach-s3c24xx/mach-smdk2443.c | 2 +-
> > arch/arm/mach-s3c24xx/s3c2410.c | 4 +-
> > arch/arm/mach-s3c24xx/s3c2412.c | 4 +-
> > arch/arm/mach-s3c24xx/s3c2416.c | 4 +-
> > arch/arm/mach-s3c24xx/s3c2440.c | 4 +-
> > arch/arm/mach-s3c24xx/s3c2442.c | 4 +-
> > arch/arm/plat-s3c24xx/Kconfig | 1 +
> > arch/arm/plat-s3c24xx/irq.c | 1092
> > +++++++++++++++----------- arch/arm/plat-samsung/include/plat/pm.h
> > | 6 -
> > arch/arm/plat-samsung/include/plat/s3c2416.h | 1 +
> > arch/arm/plat-samsung/include/plat/s3c2443.h | 2 +
> > 17 files changed, 649 insertions(+), 1209 deletions(-)
> > delete mode 100644 arch/arm/mach-s3c24xx/irq-pm.c
> > delete mode 100644 arch/arm/mach-s3c24xx/irq-s3c2416.c
> > delete mode 100644 arch/arm/mach-s3c24xx/irq-s3c2443.c
>
> Hi Heiko,
>
> Happy New Year!
a happy new year to you too
> Basically, looks OK but will look at in this weekend :-)
cool :-)
> BTW, I have no idea why you want to keep the irq.c in plat-s3c24xx. As I
> said, I'm cleaning up the plat-s3c24xx directory and it will be going
> away.
As you might have seen I tried to move it to drivers/irqchip in the past and
it seems only drivers using the new irqchip init stuff should go there now.
So I left it where it is for now, to see how far I get with the modifications
first. So, as drivers/irqchip is out of the question for now, should we move
it to mach-s3c24xx in the meantime?
As I still need to also send the redone devicetree patches on top of this
series, I could do the move there to a location you prefer :-)
Heiko
prev parent reply other threads:[~2013-01-03 0:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-01 21:51 [PATCH v2 00/11] ARM: S3C24XX: rework irq handling for a later dt usage Heiko Stübner
2013-01-01 21:52 ` [PATCH v2 01/11] ARM: S3C24XX: transform irq handling into a declarative form Heiko Stübner
2013-01-01 21:53 ` [PATCH v2 02/11] ARM: S3C24XX: move irq-pm code into main irq file Heiko Stübner
2013-01-01 21:54 ` [PATCH v2 03/11] ARM: S3C24XX: cleanup irq-pm integration Heiko Stübner
2013-01-01 21:55 ` [PATCH v2 04/11] ARM: S3C24XX: move s3c2416 irq init to common irq code Heiko Stübner
2013-01-01 21:55 ` [PATCH v2 05/11] ARM: S3C24XX: modify s3c2416 irq init to initialize all irqs Heiko Stübner
2013-01-01 21:56 ` [PATCH v2 06/11] ARM: S3C24XX: assimilate s3c2416 subirqs into new structure Heiko Stübner
2013-01-01 21:57 ` [PATCH v2 07/11] ARM: S3C24XX: assimilate second s3c2416 interrupt " Heiko Stübner
2013-01-01 21:58 ` [PATCH v2 08/11] ARM: S3C24XX: move s3c2443 irq code to irq.c Heiko Stübner
2013-01-01 21:58 ` [PATCH v2 09/11] ARM: S3C24XX: modify s3c2443 irq init to initialize all irqs Heiko Stübner
2013-01-01 21:59 ` [PATCH v2 10/11] ARM: S3C24XX: assimilate s3c2443 subirqs into new structure Heiko Stübner
2013-01-01 21:59 ` [PATCH v2 11/11] ARM: S3C24XX: remove maskack irq ack funtions Heiko Stübner
2013-01-02 23:34 ` [PATCH v2 00/11] ARM: S3C24XX: rework irq handling for a later dt usage Kukjin Kim
2013-01-03 0:48 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301030148.35569.heiko@sntech.de \
--to=heiko@sntech$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox