From: tony@atomide•com (Tony Lindgren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 2/8] ARM: dts: support pinctrl single in pxa910
Date: Thu, 3 Jan 2013 16:17:57 -0800 [thread overview]
Message-ID: <20130104001756.GO25633@atomide.com> (raw)
In-Reply-To: <1356083118-18857-3-git-send-email-haojian.zhuang@linaro.org>
Hi,
* Haojian Zhuang <haojian.zhuang@linaro•org> [121221 01:48]:
> Add pinctrl-single support with device tree in pxa910 dkb platform.
>
> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro•org>
> ---
> arch/arm/boot/dts/pxa910-dkb.dts | 204 +++++++++++++++++++++++++++++++++++++-
> arch/arm/boot/dts/pxa910.dtsi | 68 +++++++++++++
> 2 files changed, 271 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/pxa910-dkb.dts b/arch/arm/boot/dts/pxa910-dkb.dts
> index 595492a..76e9c8d 100644
> --- a/arch/arm/boot/dts/pxa910-dkb.dts
> +++ b/arch/arm/boot/dts/pxa910-dkb.dts
> @@ -24,10 +24,212 @@
>
> soc {
> apb at d4000000 {
> - uart1: uart at d4017000 {
> + pmx: pinmux at d401e000 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&board_pins>;
Looking at this maybe we should allow specifying the pinconf values at
the controller level too if the apply to all the registers:
pinctrl-single,power-source = <enableval disableval regmask>;
pinctrl-single,bias = <enableval disableval regmask>;
pinctrl-single,input-schmitt = <enableval disableval regmask>;
> +
> + board_pins: pinmux_board_pins {
> + /* pins not owned by device driver */
> + /* w1 */
> + pinctrl-single,pins = <
> + 0x0cc 0x2 /* CLK_REQ_W1 */
> + >;
> + pinctrl-single,power-source = <0x1000 0x1800>;
> + pinctrl-single,bias = <0 0xe000 0 0xa000 0xc000>;
> + pinctrl-single,input-schmitt = <0x40 0x70 0x40>;
And then you could leave them out from here for your case, while I still need
to specify them at the register level.
> + };
> + uart1_pins: pinmux_uart1_pins {
> + pinctrl-single,pins = <
> + 0x198 0x6 /* GPIO47_UART1_RXD */
> + 0x19c 0x6 /* GPIO48_UART1_TXD */
> + >;
> + /* power source, mask */
> + pinctrl-single,power-source = <0x1000 0x1800>;
> + /* bias, mask, disable, pull down, pull up */
> + pinctrl-single,bias = <0xc000 0xe000 0 0xa000 0xc000>;
> + /* input schmitt, mask, disable */
> + pinctrl-single,input-schmitt = <0x40 0x70 0x40>;
Regards,
Tony
next prev parent reply other threads:[~2013-01-04 0:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-21 9:45 [PATCH v6 0/8] pinctrl: support mmp silicon with single driver Haojian Zhuang
2012-12-21 9:45 ` [PATCH v6 1/8] pinctrl: single: support generic pinconf Haojian Zhuang
2012-12-22 1:24 ` Tony Lindgren
2013-01-04 0:14 ` Tony Lindgren
2012-12-21 9:45 ` [PATCH v6 2/8] ARM: dts: support pinctrl single in pxa910 Haojian Zhuang
2013-01-04 0:17 ` Tony Lindgren [this message]
2012-12-21 9:45 ` [PATCH v6 3/8] ARM: dts: support pinctrl single in aspenite Haojian Zhuang
2012-12-21 9:45 ` [PATCH v6 4/8] ARM: dts: support pinctrl single in brownstone Haojian Zhuang
2012-12-21 9:45 ` [PATCH v6 5/8] document: devicetree: bind pinconf with pin single Haojian Zhuang
2012-12-22 1:22 ` Tony Lindgren
2012-12-22 6:33 ` Haojian Zhuang
2012-12-22 17:07 ` Tony Lindgren
2013-01-04 0:25 ` Tony Lindgren
2012-12-21 9:45 ` [PATCH v6 6/8] tty: pxa: configure pin Haojian Zhuang
2013-01-06 23:51 ` Linus Walleij
2012-12-21 9:45 ` [PATCH v6 7/8] i2c: pxa: use devm_kzalloc Haojian Zhuang
2012-12-21 9:45 ` [PATCH v6 8/8] i2c: pxa: configure pinmux Haojian Zhuang
2013-01-06 23:52 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130104001756.GO25633@atomide.com \
--to=tony@atomide$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox