From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3.9 1/3] misc: new driver for GPIO-connected 7-segment displays
Date: Mon, 7 Jan 2013 19:43:39 +0000 [thread overview]
Message-ID: <201301071943.40074.arnd@arndb.de> (raw)
In-Reply-To: <1357576928-29133-2-git-send-email-thomas.petazzoni@free-electrons.com>
On Monday 07 January 2013, Thomas Petazzoni wrote:
> .../devicetree/bindings/misc/gpio-7seg.txt | 18 +++
> drivers/misc/Kconfig | 13 ++
> drivers/misc/Makefile | 1 +
> drivers/misc/gpio-7seg.c | 168 ++++++++++++++++++++
I wonder if it would make sense to merge this into the LED subsystem
rather than having it as a standalone driver.
> diff --git a/Documentation/devicetree/bindings/misc/gpio-7seg.txt b/Documentation/devicetree/bindings/misc/gpio-7seg.txt
> new file mode 100644
> index 0000000..107d178
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/gpio-7seg.txt
> @@ -0,0 +1,18 @@
> +* 7-segment driver connected over GPIO through a BCD decoder
> +
> +Required properties:
> +- compatible: "generic,gpio-7seg"
> +- gpios: list of GPIOs to use to control the 7-segment display
Maybe list the minimum and maximum number of gpio lines here?
> + sdev->dev_attr.attr.name = "value";
> + sdev->dev_attr.attr.mode = S_IRUGO | S_IWUGO;
> + sdev->dev_attr.show = gpio_7seg_show;
> + sdev->dev_attr.store = gpio_7seg_store;
Any reason why you are not using the DEVICE_ATTR macro?
Arnd
next prev parent reply other threads:[~2013-01-07 19:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 16:42 [PATCH 3.9] Driver for 7-segment displays connected over GPIOs Thomas Petazzoni
2013-01-07 16:42 ` [PATCH 3.9 1/3] misc: new driver for GPIO-connected 7-segment displays Thomas Petazzoni
2013-01-07 19:43 ` Arnd Bergmann [this message]
2013-01-07 19:58 ` Thomas Petazzoni
2013-01-07 21:41 ` Arnd Bergmann
2013-02-08 22:38 ` Grant Likely
2013-02-08 22:35 ` Grant Likely
2013-01-07 16:42 ` [PATCH 3.9 2/3] arm: mvebu: add the 7-segment display DT informations to Armada 370 DB Thomas Petazzoni
2013-01-07 16:42 ` [PATCH 3.9 3/3] arm: mvebu: add the 7-segment display DT informations to Armada XP DB Thomas Petazzoni
2013-02-08 22:39 ` Grant Likely
2013-01-07 16:48 ` [PATCH 3.9] Driver for 7-segment displays connected over GPIOs Greg Kroah-Hartman
2013-01-07 17:07 ` Thomas Petazzoni
2013-01-07 17:23 ` Greg Kroah-Hartman
2013-01-07 17:40 ` Thomas Petazzoni
2013-01-07 17:43 ` Thomas Petazzoni
2013-01-07 17:56 ` H Hartley Sweeten
2013-01-07 18:02 ` Jason Cooper
2013-01-07 18:06 ` Russell King - ARM Linux
2013-01-07 17:53 ` Thomas Petazzoni
2013-01-07 18:36 ` Greg Kroah-Hartman
2013-01-07 18:38 ` Thomas Petazzoni
2013-01-07 23:05 ` Linus Walleij
2013-02-09 16:28 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301071943.40074.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox