From: catalin.marinas@arm•com (Catalin Marinas)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/4] irqchip: gic: Perform the gic_secondary_init() call via CPU notifier
Date: Fri, 25 Jan 2013 18:12:20 +0000 [thread overview]
Message-ID: <20130125181220.GB9754@arm.com> (raw)
In-Reply-To: <1359130578.32148.1.camel@linux-builds1>
On Fri, Jan 25, 2013 at 04:16:18PM +0000, Dinh Nguyen wrote:
> Hi Catalin,
>
> On Wed, 2013-01-23 at 17:59 +0000, Catalin Marinas wrote:
> > All the calls to gic_secondary_init() pass 0 as the first argument.
> > Since this function is called on each CPU when starting, it can be done
> > in a platform-independent way via a CPU notifier registered by the GIC
> > code.
> >
> > Signed-off-by: Catalin Marinas <catalin.marinas@arm•com>
> > Cc: Russell King <linux@arm•linux.org.uk>
> > Cc: Thomas Gleixner <tglx@linutronix•de>
> > Cc: Kukjin Kim <kgene.kim@samsung•com>
> > Cc: Rob Herring <rob.herring@calxeda•com>
> > Cc: Sascha Hauer <kernel@pengutronix•de>
> > Cc: David Brown <davidb@codeaurora•org>
> > Cc: Daniel Walker <dwalker@fifo99•com>
> > Cc: Bryan Huntsman <bryanh@codeaurora•org>
> > Cc: Tony Lindgren <tony@atomide•com>
> > Cc: Simon Horman <horms@verge•net.au>
> > Cc: Magnus Damm <magnus.damm@gmail•com>
> > Cc: Dinh Nguyen <dinguyen@altera•com>
> > Cc: Viresh Kumar <viresh.linux@gmail•com>
> > Cc: Shiraz Hashim <shiraz.hashim@st•com>
> > Cc: Stephen Warren <swarren@wwwdotorg•org>
> > Cc: Srinidhi Kasagar <srinidhi.kasagar@stericsson•com>
> > Cc: Linus Walleij <linus.walleij@linaro•org>
> > ---
> >
> > Randomly chosen CPU notifier priority. I can add a definition somewhere
> > though they don't seem to be used much and cause conflicts.
> >
> > arch/arm/mach-exynos/platsmp.c | 8 --------
> > arch/arm/mach-highbank/platsmp.c | 7 -------
> > arch/arm/mach-imx/platsmp.c | 12 ------------
> > arch/arm/mach-msm/platsmp.c | 8 --------
> > arch/arm/mach-omap2/omap-smp.c | 7 -------
> > arch/arm/mach-shmobile/smp-emev2.c | 7 -------
> > arch/arm/mach-shmobile/smp-r8a7779.c | 7 -------
> > arch/arm/mach-shmobile/smp-sh73a0.c | 7 -------
> > arch/arm/mach-socfpga/platsmp.c | 12 ------------
>
> For socfpga, I get this error when I build for sofpga_defconfig:
>
> drivers/gpio/gpio-pl061.c: In function ?pl061_irq_handler?:
> drivers/gpio/gpio-pl061.c:183:2: error: implicit declaration of function
> ?chained_irq_enter? [-Werror=implicit-function-declaration]
> drivers/gpio/gpio-pl061.c:192:2: error: implicit declaration of function
> ?chained_irq_exit? [-Werror=implicit-function-declaration]
Ah, I only grep'ed arch/arm for chained_irq_enter() use. The simplest
for arch/arm is to actually include chained_irq.h into asm/mach/irq.h
since the latter is already included. For code shared with arm64 I'll
just include chained_irq.h explicitly.
Thanks.
--
Catalin
prev parent reply other threads:[~2013-01-25 18:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 17:59 [PATCH 0/4] Preparatory GIC patches for arm64 support Catalin Marinas
2013-01-23 17:59 ` [PATCH 1/4] arm: Move the set_handle_irq and handle_arch_irq declarations to asm/irq.h Catalin Marinas
2013-01-23 17:59 ` [PATCH 2/4] arm: Move chained_irq_(enter|exit) to a generic file Catalin Marinas
2013-01-24 5:32 ` Santosh Shilimkar
2013-01-24 17:29 ` Catalin Marinas
2013-01-25 7:00 ` Santosh Shilimkar
2013-01-23 17:59 ` [PATCH 3/4] irqchip: gic: Call handle_bad_irq() directly Catalin Marinas
2013-01-23 17:59 ` [PATCH 4/4] irqchip: gic: Perform the gic_secondary_init() call via CPU notifier Catalin Marinas
2013-01-23 18:28 ` Stephen Warren
2013-01-24 2:15 ` Viresh Kumar
2013-01-24 5:33 ` Santosh Shilimkar
2013-01-24 17:51 ` Rob Herring
2013-01-25 4:30 ` Simon Horman
2013-01-25 9:25 ` Catalin Marinas
2013-01-28 1:03 ` Simon Horman
2013-01-25 11:25 ` Srinidhi Kasagar
2013-01-25 16:16 ` Dinh Nguyen
2013-01-25 18:12 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125181220.GB9754@arm.com \
--to=catalin.marinas@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox