From: gmbnomis@gmail•com (Simon Baatz)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/2] ARM: kirkwood: Ensure that kirkwood_ge0[01]_init() finds its clock
Date: Wed, 30 Jan 2013 09:30:44 +0100 [thread overview]
Message-ID: <20130130083044.GA25688@schnuecks.de> (raw)
In-Reply-To: <51086E86.8040705@gmail.com>
On Wed, Jan 30, 2013 at 01:51:18AM +0100, Sebastian Hesselbarth wrote:
> above using CLK_IGNORE_UNUSED on runit maybe is the best.
> >Fine with all of that. But: I am talking about 3.8 all the time. We
> >have three options for issues 2 and 3 from my point of view:
> >
> >1. We do proper fixes in 3.8 for issues 2 and 3.
> >
> >2. We fix this regression by not gating the clock in both the DT and
> >the non-DT case, preferably by using the correct clocks in
> >kirkwood_ge0[01]_init(). Additionally, Jason promises that all gets
> >well with the DT aware driver in 3.9. ;-)
> >
> >3. Do nothing. Simply accept that we broke modular Ethernet for DT
> >because some code relies on two pointers being set. When we
> >introduced a new code path for DT, we forgot about these pointers.
> >Bad luck, the solution was not nice anyway and we will do proper
> >fixes in 3.9.
> >
> >As should be clear by now, I think we should go for option 2.
>
> Agreed, do you think all issues you are suffering will be solved with:
>
> - [PATCH v2 2/2] clk: mvebu: Do not gate runit clock on Kirkwood
> (no lockup for minimal kernel configs)
>
> - [PATCH] NET: mv643xx: get smi clock from device tree
> (no lockup for modular DT ethernet)
>
> - Some patch that adds MV643XX_ETH_SHARED_NAME ".0" and ".1" clk aliases
> (no lockup for modular non-DT ethernet)
I think your patch to get the smi clock is intended for device tree.
Thus, the driver won't use these aliases, right?
> - Some patch that adds clk_prepare_enable to ge0/ge1 clocks to
> kirkwood_legacy_clk_init()
> (retain MAC address for modular DT ethernet)
I like mine better, since it only enables the clocks of the
interfaces that are initialized in the init code. I tested it with
non-DT as well. But either is fine with me.
> I'll prepare the latter patches and post them.
Thanks!
- Simon
next prev parent reply other threads:[~2013-01-30 8:30 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-27 10:40 [PATCH v2 0/2] Do not gate ge0/1 and runit clocks on Kirkwood Simon Baatz
2013-01-27 10:40 ` [PATCH v2 1/2] ARM: kirkwood: Ensure that kirkwood_ge0[01]_init() finds its clock Simon Baatz
2013-01-27 10:52 ` Sebastian Hesselbarth
2013-01-27 11:08 ` Simon Baatz
2013-01-27 11:18 ` Sebastian Hesselbarth
2013-01-27 14:19 ` Sebastian Hesselbarth
2013-01-27 14:46 ` Jason Cooper
2013-01-27 14:53 ` Sebastian Hesselbarth
2013-01-27 15:24 ` Jason Cooper
2013-01-28 22:31 ` Simon Baatz
2013-01-29 0:48 ` Jason Cooper
2013-01-29 19:42 ` Simon Baatz
2013-01-29 20:08 ` Sebastian Hesselbarth
2013-01-29 20:32 ` Jason Cooper
2013-01-29 20:48 ` Sebastian Hesselbarth
2013-01-29 21:23 ` Jason Cooper
2013-01-30 22:43 ` Jason Cooper
2013-01-30 23:05 ` Jason Gunthorpe
2013-01-31 0:29 ` Jason Cooper
2013-01-31 0:39 ` Jason Gunthorpe
2013-01-30 0:03 ` Simon Baatz
2013-01-30 0:51 ` Sebastian Hesselbarth
2013-01-30 4:26 ` Jason Cooper
2013-01-30 8:30 ` Simon Baatz [this message]
2013-01-30 10:16 ` Sebastian Hesselbarth
2013-01-30 14:53 ` Simon Baatz
2013-01-30 23:01 ` Jason Cooper
2013-01-30 23:15 ` Jason Gunthorpe
2013-01-31 0:40 ` Jason Cooper
2013-01-30 23:22 ` Sebastian Hesselbarth
2013-01-31 0:32 ` Jason Cooper
2013-01-31 22:26 ` Simon Baatz
2013-01-31 22:44 ` Simon Baatz
2013-01-31 22:49 ` Sebastian Hesselbarth
2013-02-01 0:11 ` Jason Cooper
2013-02-01 0:01 ` Jason Cooper
2013-02-01 0:19 ` Jason Gunthorpe
2013-02-01 6:14 ` Andrew Lunn
2013-02-01 6:46 ` Jason Gunthorpe
2013-02-02 23:04 ` Simon Baatz
2013-02-03 16:45 ` Jason Cooper
2013-01-28 18:28 ` Jason Gunthorpe
2013-01-29 6:56 ` Andrew Lunn
2013-01-29 17:29 ` Jason Gunthorpe
2013-01-28 18:22 ` Jason Gunthorpe
2013-01-28 19:46 ` Jason Cooper
2013-01-29 19:54 ` Simon Baatz
2013-01-29 21:13 ` Jason Cooper
2013-01-28 20:26 ` Jason Cooper
2013-01-27 10:40 ` [PATCH v2 2/2] clk: mvebu: Do not gate runit clock on Kirkwood Simon Baatz
2013-01-27 10:55 ` Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130130083044.GA25688@schnuecks.de \
--to=gmbnomis@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox