Subject: [RESEND PATCH v5 3/7] usb: chipidea: add otg id switch and vbus connect/disconnect detect

From: [email-masked] (Peter Chen)
Date: Thu, 31 Jan 2013 10:02:17 +0800

On Wed, Jan 30, 2013 at 12:31:04PM +0200, Alexander Shishkin wrote:
> Peter Chen <[email-masked]> writes:
> 
> > On Wed, Jan 30, 2013 at 11:36:42AM +0530, kishon wrote:
> >> Hi,
> >> 
> >> >  	bool				global_phy;
> >> >  	struct usb_phy			*transceiver;
> >> >  	struct usb_hcd			*hcd;
> >> >-	struct usb_otg      otg;
> >> >+	struct usb_otg      		otg;
> >> You have added *otg* in previous patch and added a tab for *otg* in
> >> this patch.
> > thanks, I will change at previous patch
> >> 
> >> >+
> >> >+#define CI_VBUS_STABLE_TIMEOUT 500
> >> 
> >> Just curious.. how was this timeout value obtained?
> >
> > Just a timeout value, if the vbus goes to required value, it will quit.
> > Besides, 5s for vbus stable should be enough for an well behaviour hardware.
> 
> Can you also mention this in the patch, since it raises questions?

Sure, do you have other ideas about next version patch?
> Thanks,
> --
> Alex

-- 

Best Regards,
Peter Chen