From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/5] dmaengine: dw_dmac: move to generic DMA binding
Date: Fri, 15 Feb 2013 11:17:42 +0000 [thread overview]
Message-ID: <201302151117.43187.arnd@arndb.de> (raw)
In-Reply-To: <1360918222.28241.20.camel@smile>
On Friday 15 February 2013, Andy Shevchenko wrote:
> Have one question and one comment.
>
> So, what is the status of this work? Do you manage to provide something
> for v3.9? (Oh, two questions :-) )
I was going to bring it up today myself. Unfortunately the patches have
never been tested on real hardware and I have not posted a version that
includes the feedback I got, so I don't think it's a good idea to
use this in v3.9. However, not doing it causes problems since Vinod's
dma-slave tree still contains Viresh's earlier patches, causing
a few problems:
* With these patches, the spear3xx platform currently does not build.
(this one is easy to fix though)
* There is a conflict between these patches and my spear multiplatform
series, which I have not yet queued up for 3.9 because of this,
since that would have meant that Stephen Rothwell would have to
discard either the arm-soc tree or the dma-slave tree from linux-next.
* I really don't want the broken binding to appear in 3.9.
I believe the best way out at this point is that I do an updated
version of my patch, and Vinod first reverts the patch f9965aa20
"ARM: SPEAr13xx: Pass DW DMAC platform data from DT" in his tree
and then applies my update. This will give us the right DT binding
for dw-dmac but no in-tree users, which means that nothing breaks
if I get it wrong.
I can then decide with Olof whether or not to take the spear multiplatform
changes that no longer conflict with the dma slave tree as a "late"
branch into 3.9 or wait until 3.10, but that is something you don't
need to worry about then. Also the conversion of spear to use
the new binding (patch 5 of this series) can go through the arm-soc
tree for 3.10 after the ST folks have tested that it works.
> > --- a/drivers/dma/dw_dmac.c
> > +++ b/drivers/dma/dw_dmac.c
>
> > @@ -1765,7 +1753,11 @@ static int dw_probe(struct platform_device *pdev)
> >
> > dma_async_device_register(&dw->dma);
> >
> > - return 0;
> > + err = of_dma_controller_register(pdev->dev.of_node, dw_dma_xlate, dw);
> > + if (err)
> > + dma_async_device_unregister(&dw->dma);
>
> I don't think this is a good idea. The impossibility to register in the
> of-dma helper is not critical. Just printing debug message is enough.
Ok, makes sense. Thanks!
Arnd
next prev parent reply other threads:[~2013-02-15 11:17 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1359395857-1235-1-git-send-email-arnd@arndb.de>
2013-01-28 21:58 ` [PATCH v2 0/5] dmaengine: convert dw_dmac/spear13xx to generic binding Arnd Bergmann
2013-01-28 21:58 ` [PATCH 1/5] dmaengine: dw_dmac: move to generic DMA binding Arnd Bergmann
2013-01-29 7:24 ` Viresh Kumar
2013-01-29 10:35 ` Arnd Bergmann
2013-01-29 10:49 ` Viresh Kumar
2013-01-29 10:54 ` Andy Shevchenko
2013-01-29 10:57 ` Viresh Kumar
2013-01-29 11:14 ` Andy Shevchenko
2013-01-29 13:31 ` Arnd Bergmann
2013-01-29 13:45 ` Andy Shevchenko
2013-01-29 14:26 ` Russell King - ARM Linux
2013-01-29 15:28 ` Arnd Bergmann
2013-01-29 15:17 ` Viresh Kumar
2013-01-29 16:21 ` Arnd Bergmann
2013-01-30 2:04 ` Viresh Kumar
2013-01-30 9:41 ` Arnd Bergmann
2013-01-30 9:48 ` Viresh Kumar
2013-01-30 10:08 ` Arnd Bergmann
2013-01-30 10:32 ` Viresh Kumar
[not found] ` <1359445171.31148.30.camel@smile>
2013-01-29 10:50 ` Arnd Bergmann
2013-01-29 11:18 ` Russell King - ARM Linux
2013-01-29 13:44 ` Arnd Bergmann
2013-01-29 14:24 ` Russell King - ARM Linux
2013-01-29 14:55 ` Arnd Bergmann
2013-01-29 15:44 ` Russell King - ARM Linux
2013-01-29 16:36 ` Arnd Bergmann
2013-01-29 17:45 ` Russell King - ARM Linux
2013-01-29 20:40 ` Arnd Bergmann
2013-01-29 21:59 ` Linus Walleij
2013-02-15 8:50 ` Andy Shevchenko
2013-02-15 11:17 ` Arnd Bergmann [this message]
2013-01-28 21:58 ` [PATCH 2/5] spi: pl022: use generic DMA slave configuration if possible Arnd Bergmann
2013-01-29 2:41 ` Mark Brown
2013-01-29 7:49 ` Andy Shevchenko
2013-01-29 13:13 ` Arnd Bergmann
2013-02-07 18:29 ` Linus Walleij
2013-02-07 19:42 ` Arnd Bergmann
2013-02-07 20:19 ` Linus Walleij
2013-02-07 21:15 ` Arnd Bergmann
2013-02-08 16:22 ` Russell King - ARM Linux
2013-02-08 16:28 ` Arnd Bergmann
2013-02-08 22:10 ` Linus Walleij
2013-02-08 16:20 ` Russell King - ARM Linux
2013-01-28 21:58 ` [PATCH 3/5] serial: pl011: " Arnd Bergmann
2013-01-30 4:38 ` Greg Kroah-Hartman
2013-01-28 21:58 ` [PATCH 4/5] ata: arasan: remove the need for platform_data Arnd Bergmann
2013-01-29 8:18 ` Viresh Kumar
2013-01-28 21:58 ` [PATCH 5/5] ARM: SPEAr13xx: Pass generic DW DMAC platform data from DT Arnd Bergmann
2013-01-29 8:16 ` Viresh Kumar
2013-01-29 13:21 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201302151117.43187.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox