From: mturquette@linaro•org (Mike Turquette)
To: linux-arm-kernel@lists•infradead.org
Subject: randconfig errors
Date: Fri, 15 Feb 2013 12:11:21 -0800 [thread overview]
Message-ID: <20130215201121.11471.66349@quantum> (raw)
In-Reply-To: <201302151800.36948.arnd@arndb.de>
Quoting Arnd Bergmann (2013-02-15 10:00:36)
> On Friday 15 February 2013, Rob Herring wrote:
> > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/clk/clk-vt8500.c:160:24: error: 'prate' undeclared (first use in this function)
>
> I've seen this one with allyesconfig but have not tried to make a fix
Looks like this one was introduced by 7248001, "clk: vt8500: Fix device
clock divisor calculations".
Looks like a copy/paste error where prate was used instead of
parent_rate.
Tony can you test the below patch?
Regards,
Mike
>From efb8dbe114579b4f459b3810e83d79b11593436a Mon Sep 17 00:00:00 2001
From: Mike Turquette <mturquette@linaro•org>
Date: Fri, 15 Feb 2013 12:03:51 -0800
Subject: [PATCH] clk: vt8500: copy-paste mistake in dclk_set_rate
Commit 7248001, "clk: vt8500: Fix device clock divisor calculations"
introduced logic to improve divider selection while changing rates for
the VT8500 dclk. However a copy-paste error results in using the wrong
variable name in the .set_rate callback. Fixed by changing *prate to
parent_rate. The .round_rate function is correct and remains unchanged.
Signed-off-by: Mike Turquette <mturquette@linaro•org>
Cc: Tony Prisk <linux@prisktech•co.nz>
Cc: Arnd Bergmann <arnd@arndb•de>
Cc: Rob Herring <robherring2@gmail•com>
---
drivers/clk/clk-vt8500.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c
index b5538bb..c010861 100644
--- a/drivers/clk/clk-vt8500.c
+++ b/drivers/clk/clk-vt8500.c
@@ -156,8 +156,8 @@ static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate,
divisor = parent_rate / rate;
- /* If prate / rate would be decimal, incr the divisor */
- if (rate * divisor < *prate)
+ /* If parent_rate / rate would be decimal, incr the divisor */
+ if (rate * divisor < parent_rate)
divisor++;
if (divisor == cdev->div_mask + 1)
--
1.7.10.4
next prev parent reply other threads:[~2013-02-15 20:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 17:25 randconfig errors Rob Herring
2013-02-15 18:00 ` Arnd Bergmann
2013-02-15 20:11 ` Mike Turquette [this message]
2013-02-15 20:28 ` Troy Kisky
2013-02-22 9:29 ` Arnd Bergmann
2013-02-15 18:22 ` Marc Zyngier
2013-02-15 18:47 ` Marc Zyngier
2013-02-15 19:16 ` Christoffer Dall
2013-02-15 19:22 ` Marc Zyngier
2013-02-15 19:24 ` Christoffer Dall
[not found] ` <c01a8ed845054b9d9cbddb341bac5f0e@DLEE74.ent.ti.com>
2013-02-15 19:45 ` Matt Porter
2013-02-15 20:12 ` Arnd Bergmann
2013-02-15 20:25 ` Chris Ball
2013-02-20 6:36 ` Vinod Koul
2013-02-20 9:53 ` Arnd Bergmann
2013-02-21 10:38 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130215201121.11471.66349@quantum \
--to=mturquette@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox