From: broonie@opensource•wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 07/10] ASoC: phycore-ac97: Add DT support
Date: Tue, 12 Mar 2013 18:59:22 +0000 [thread overview]
Message-ID: <20130312185921.GX19942@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1362940391-8338-8-git-send-email-mpa@pengutronix.de>
On Sun, Mar 10, 2013 at 07:33:08PM +0100, Markus Pargmann wrote:
> Add devicetree support for this audio soc fabric driver.
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix•de>
> ---
> sound/soc/fsl/phycore-ac97.c | 148 ++++++++++++++++++++++++++++++++++++-------
> 1 file changed, 125 insertions(+), 23 deletions(-)
A binding document is mandatory for new bindings.
> +#ifdef CONFIG_MACH_IMX27_DT
> + .cpu_dai_name = "10010000.ssi",
> + .platform_name = "imx-fiq-pcm-audio",
> +#else
This looks wrong, at least the CPU DAI name should be being looked up
via the DT.
> +static const struct of_device_id imx_phycore_ac97_of_dev_id[] = {
> + {
> + .compatible = "phytec,imx27-pca100-ac97",
> + .data = (void *)MX27_PCA100,
> + }, {
> + .compatible = "phytec,imx27-pcm043-ac97",
> + .data = (void *)MX27_PCM043
> + }, {
> + /* sentinel */
> + }
> +};
> +MODULE_DEVICE_TABLE(of, imx_phycore_ac97_of_dev_id);
It seems like we ought to be able to describe the properties of the
boards in this class rather than just enumerating the boards. What are
the differences?
> MODULE_AUTHOR("Sascha Hauer <s.hauer@pengutronix•de>");
> -MODULE_DESCRIPTION("PhyCORE ALSA SoC driver");
> +MODULE_DESCRIPTION(DRV_NAME ": PhyCORE ALSA SoC fabric driver");
Please don't make up terms like "fabric driver".
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130312/a164cce8/attachment.sig>
next prev parent reply other threads:[~2013-03-12 18:59 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-10 18:33 [PATCH 00/10] ASoC: imx sound: Add DT support Markus Pargmann
2013-03-10 18:33 ` [PATCH 01/10] imx-ssi: Fix AC97 rates Markus Pargmann
2013-03-10 18:47 ` Fabio Estevam
2013-03-11 19:51 ` Markus Pargmann
2013-03-13 22:55 ` Timur Tabi
2013-03-14 12:44 ` Markus Pargmann
2013-03-12 18:52 ` Mark Brown
2013-03-10 18:33 ` [PATCH 02/10] imx-ssi: Fix occasional AC97 reset failure Markus Pargmann
2013-03-12 18:53 ` Mark Brown
2013-03-10 18:33 ` [PATCH 03/10] mx-ssi: flush fifos Markus Pargmann
2013-03-12 18:54 ` Mark Brown
2013-03-10 18:33 ` [PATCH 04/10] ASoC: Kconfig: imx-ssi needs imx-fiq and imx-dma Markus Pargmann
2013-03-12 18:55 ` Mark Brown
2013-03-14 12:42 ` Markus Pargmann
2013-03-10 18:33 ` [PATCH 05/10] ASoC: pcm030 audio fabric: remove __init from probe Markus Pargmann
2013-03-12 18:55 ` Mark Brown
2013-03-10 18:33 ` [PATCH 06/10] ARM: soc-audio phycore-ac97: fix driver init order Markus Pargmann
2013-03-11 11:10 ` Mark Brown
2013-03-11 19:56 ` Markus Pargmann
2013-03-10 18:33 ` [PATCH 07/10] ASoC: phycore-ac97: Add DT support Markus Pargmann
2013-03-12 18:59 ` Mark Brown [this message]
2013-03-14 12:55 ` Markus Pargmann
2013-03-10 18:33 ` [PATCH 08/10] ASoC: dmaengine_pcm: Add open function for DT DMA request Markus Pargmann
2013-03-12 19:02 ` Mark Brown
2013-03-13 2:18 ` Shawn Guo
2013-03-13 10:49 ` Mark Brown
2013-03-14 6:04 ` Shawn Guo
2013-03-15 1:12 ` Mark Brown
2013-03-14 13:08 ` Markus Pargmann
2013-03-15 3:42 ` Shawn Guo
2013-03-15 9:07 ` Markus Pargmann
2013-03-10 18:33 ` [PATCH 09/10] ASoC: imx-pcm-dma: Add support for DMA init by device node Markus Pargmann
2013-03-10 18:33 ` [PATCH 10/10] ASoC: imx-ssi: Add imx27 and pca100 DT support Markus Pargmann
2013-03-10 18:55 ` Alexander Shiyan
2013-03-13 22:53 ` [PATCH 00/10] ASoC: imx sound: Add " Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130312185921.GX19942@opensource.wolfsonmicro.com \
--to=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox