From: ludovic.desroches@atmel•com (ludovic.desroches at atmel.com)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/4] ARM: at91: introduce SAMA5 support
Date: Tue, 19 Mar 2013 12:23:38 +0100 [thread overview]
Message-ID: <20130319112338.GE2522@ludovic.desroches@atmel.com> (raw)
In-Reply-To: <51420885.60006@arm.com>
On Thu, Mar 14, 2013 at 05:27:33PM +0000, Marc Zyngier wrote:
> On 14/03/13 17:05, ludovic.desroches at atmel.com wrote:
> > From: Ludovic Desroches <ludovic.desroches@atmel•com>
> >
> > This patch introduces the SAMA5 support. It also updates the PMC driver to
> > manage clock division which is a requirement since some peripherals can't work
> > at the bus frequency on SAMA5.
> >
> > Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel•com>
> > Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel•com>
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft•com>
> > Tested-by: Robert Nelson <robertcnelson@gmail•com>
> > ---
> > arch/arm/boot/dts/Makefile | 5 +
> > arch/arm/boot/dts/sama5d3.dtsi | 1031 ++++++++++++++++++++++++++++
> > arch/arm/boot/dts/sama5d31ek.dts | 51 ++
> > arch/arm/boot/dts/sama5d33ek.dts | 44 ++
> > arch/arm/boot/dts/sama5d34ek.dts | 61 ++
> > arch/arm/boot/dts/sama5d35ek.dts | 56 ++
> > arch/arm/boot/dts/sama5d3xcm.dtsi | 91 +++
> > arch/arm/boot/dts/sama5d3xdm.dtsi | 42 ++
> > arch/arm/boot/dts/sama5d3xmb.dtsi | 166 +++++
> > arch/arm/configs/sama5_defconfig | 181 +++++
> > arch/arm/mach-at91/Kconfig | 33 +
> > arch/arm/mach-at91/Makefile | 4 +
> > arch/arm/mach-at91/board-dt-sama5.c | 86 +++
> > arch/arm/mach-at91/clock.c | 109 ++-
> > arch/arm/mach-at91/clock.h | 2 +
> > arch/arm/mach-at91/include/mach/at91_pmc.h | 18 +-
> > arch/arm/mach-at91/include/mach/cpu.h | 20 +
> > arch/arm/mach-at91/include/mach/sama5d3.h | 73 ++
> > arch/arm/mach-at91/sama5d3.c | 377 ++++++++++
> > arch/arm/mach-at91/setup.c | 27 +
> > arch/arm/mach-at91/soc.h | 5 +
> > 21 files changed, 2453 insertions(+), 29 deletions(-)
> > create mode 100644 arch/arm/boot/dts/sama5d3.dtsi
> > create mode 100644 arch/arm/boot/dts/sama5d31ek.dts
> > create mode 100644 arch/arm/boot/dts/sama5d33ek.dts
> > create mode 100644 arch/arm/boot/dts/sama5d34ek.dts
> > create mode 100644 arch/arm/boot/dts/sama5d35ek.dts
> > create mode 100644 arch/arm/boot/dts/sama5d3xcm.dtsi
> > create mode 100644 arch/arm/boot/dts/sama5d3xdm.dtsi
> > create mode 100644 arch/arm/boot/dts/sama5d3xmb.dtsi
> > create mode 100644 arch/arm/configs/sama5_defconfig
> > create mode 100644 arch/arm/mach-at91/board-dt-sama5.c
> > create mode 100644 arch/arm/mach-at91/include/mach/sama5d3.h
> > create mode 100644 arch/arm/mach-at91/sama5d3.c
>
> So I haven't started reviewing this yet, but looking at the diffstat, I
> can't help but think this patch could use some splitting to be more
> easily reviewable.
>
> How about having one patch for the clock stuff, one for the config, one
> for the DT, and finally one for the SoC support itself?
>
Hello Marc,
As you said I can split dts/dtsi, defconf to have a more easily reviewable
patch. On the other side, I know that some people prefer to have the whole
'functionnality' in one patch.
Concerning clock stuff and SoC support, they are tied:
- I use cpu_is_sama5d3 macro in clock.c
- in sama5d3.c I am using the new fields (div and pid) introduced by the clock.c
update.
Regards
Ludovic
next prev parent reply other threads:[~2013-03-19 11:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 17:05 [PATCH v2 0/4] SAMA5D3 support ludovic.desroches at atmel.com
2013-03-14 17:05 ` [PATCH 1/4] ARM: at91: change name template in AT91_SOC_START macro ludovic.desroches at atmel.com
2013-03-14 17:05 ` [PATCH 2/4] ARM: at91: add AT91_SAM9_TIME entry to select at91sam926x_time.c compilation ludovic.desroches at atmel.com
2013-03-14 17:05 ` [PATCH 3/4] ARM: at91: introduce the core type choice to split ARMv4/5 and ARMv7 arch ludovic.desroches at atmel.com
2013-03-14 17:05 ` [PATCH 4/4] ARM: at91: introduce SAMA5 support ludovic.desroches at atmel.com
2013-03-14 17:27 ` Marc Zyngier
2013-03-19 11:23 ` ludovic.desroches at atmel.com [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-03-08 15:13 [PATCH 0/4] SAMA5D3 support ludovic.desroches at atmel.com
2013-03-08 15:13 ` [PATCH 4/4] ARM: at91: introduce SAMA5 support ludovic.desroches at atmel.com
2013-03-08 16:40 ` Joachim Eastwood
2013-03-08 16:52 ` Ludovic Desroches
[not found] ` <513a1756.e94aec0a.1f22.6694SMTPIN_ADDED_BROKEN@mx.google.com>
2013-03-08 17:18 ` Joachim Eastwood
2013-03-08 18:56 ` Jean-Christophe PLAGNIOL-VILLARD
2013-03-08 21:27 ` Joachim Eastwood
2013-03-11 12:35 ` Jean-Christophe PLAGNIOL-VILLARD
2013-03-13 14:35 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130319112338.GE2522@ludovic.desroches@atmel.com \
--to=ludovic.desroches@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox