From: mturquette@linaro•org (Mike Turquette)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] clk: add table lookup to mux
Date: Wed, 20 Mar 2013 08:51:58 -0700 [thread overview]
Message-ID: <20130320155158.11073.43798@quantum> (raw)
In-Reply-To: <20130320094957.GG18519@tbergstrom-lnx.Nvidia.com>
Quoting Peter De Schrijver (2013-03-20 02:49:57)
> On Wed, Mar 20, 2013 at 12:51:10AM +0100, Mike Turquette wrote:
> > Quoting Peter De Schrijver (2013-03-12 11:42:23)
> > > diff --git a/include/linux/clk-private.h b/include/linux/clk-private.h
> > > index 9c7f580..53d39c2 100644
> > > --- a/include/linux/clk-private.h
> > > +++ b/include/linux/clk-private.h
> > > @@ -144,12 +144,13 @@ struct clk {
> > >
> > > #define DEFINE_CLK_MUX(_name, _parent_names, _parents, _flags, \
> > > _reg, _shift, _width, \
> > > - _mux_flags, _lock) \
> > > + _mux_flags, _table, _lock) \
> > > static struct clk _name; \
> > > static struct clk_mux _name##_hw = { \
> > > .hw = { \
> > > .clk = &_name, \
> > > }, \
> > > + .table = _table, \
> > > .reg = _reg, \
> > > .shift = _shift, \
> > > .width = _width, \
> >
> > This breaks OMAP horribly since OMAP already uses this macro. There are
> > two options:
> >
> > 1) stop using statically initialized data and no longer use
> > clk-private.h macros. I was under the impression that the tegra clock
> > data no longer required this?
>
> Ok. We don't do that anymore. Maybe I just modified it out of habbit...
>
Cool. Will you send a V2 that drops the macro changes?
Thanks,
Mike
> >
> > 2) if you must continue to use the clk-private.h macros (temporarily!)
> > then create a new one, DEFINE_CLK_MUX_TABLE.
>
> Hopefully not needed.
>
> Cheers,
>
> Peter.
next prev parent reply other threads:[~2013-03-20 15:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 18:42 [PATCH] clk: add table lookup to mux Peter De Schrijver
2013-03-12 18:53 ` Stephen Warren
2013-03-19 21:37 ` Mike Turquette
2013-03-19 21:43 ` Stephen Warren
2013-03-19 21:33 ` Mike Turquette
2013-03-19 21:42 ` Stephen Warren
2013-03-20 9:40 ` Peter De Schrijver
2013-03-19 23:51 ` Mike Turquette
2013-03-20 9:49 ` Peter De Schrijver
2013-03-20 15:51 ` Mike Turquette [this message]
2013-03-21 9:45 ` Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130320155158.11073.43798@quantum \
--to=mturquette@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox