Subject: [PATCH 1/2] ARM: kirkwood: fix a not initialized variable in the sound subsystem

From: [email-masked] (Jean-Francois Moine)
Date: Tue, 26 Mar 2013 21:05:12 +0100

On Tue, 26 Mar 2013 20:41:40 +0100
Sebastian Hesselbarth <[email-masked]> wrote:

> On 03/26/2013 07:05 PM, Jean-Francois Moine wrote:
> > In the function kirkwood_set_rate, in case of a non dco supported rate
> > and no external clock, the clock source was set to an undefined value.
> > This patch just displays a message without changing the clock source.
> >
> > Signed-off-by: Jean-Francois Moine<[email-masked]>
> > ---
> >   sound/soc/kirkwood/kirkwood-i2s.c |    3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/sound/soc/kirkwood/kirkwood-i2s.c b/sound/soc/kirkwood/kirkwood-i2s.c
> > index c74c890..afca1ec 100644
> > --- a/sound/soc/kirkwood/kirkwood-i2s.c
> > +++ b/sound/soc/kirkwood/kirkwood-i2s.c
> > @@ -118,6 +118,9 @@ static void kirkwood_set_rate(struct snd_soc_dai *dai,
> >   		clk_set_rate(priv->extclk, 256 * rate);
> >
> >   		clks_ctrl = KIRKWOOD_MCLK_SOURCE_EXTCLK;
> > +	} else {
> > +		dev_err(dai->dev, "%s: no clock\n", __func__);
> > +		return;
> >   	}
> >   	writel(clks_ctrl, priv->io + KIRKWOOD_CLOCKS_CTRL);
> >   }
> 
> NACK.
> 
> Having no clock at all should be catched during _probe. Moreover,
> not having the internal clock enabled will lead to system hang due to
> clock gating. You should rather pass an optional (DT-only) extclk phandle
> on the second clocks property.
> 
> Sebastian
> 
> P.S. as this is alsa stuff you should have some alsa maintainers on your
> Cc list. Please run ./scripts/get_maintainer.pl on your patches next time.
> It will give you a list of people you have to to Cc.

It is a compilation error: the variable clks_ctrl is not initialized.

The sequence has been created by the commit 363589bf110aa0352a2031
   "ASoC: kirkwood-i2s: add support for external clock rates"
Russell is in the Cc list.

-- 
Ken ar c'henta?	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/