From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 04/10] arm: zynq: Load scu baseaddress at run time
Date: Wed, 27 Mar 2013 09:29:45 +0000 [thread overview]
Message-ID: <201303270929.45733.arnd@arndb.de> (raw)
In-Reply-To: <CAHTX3dJoAW=KPAS4x-==bLY-COxCXPKdtNuEMGZEu-npR5t-hg@mail.gmail.com>
On Wednesday 27 March 2013, Michal Simek wrote:
> 2013/3/26 Arnd Bergmann <arnd@arndb•de>:
> > On Tuesday 26 March 2013, Michal Simek wrote:
> >> +void __iomem *scu_base;
> >> +
> >
> > This cannot be a global variable in a multiplatform kernel. Can you
> > make it static?
>
> This global variable is shared because I am using it in smp code
> and also it will be used in pm code we have.
>
> What is it another way how to handle this?
>
> Because the same problem could be with zynq_slcr_base.
>
> Or the rule is just to use zynq_ prefix for all global variables?
>
Yes. The best solution is to mke variables local to some context and
only pointed to by other data structures. If that doesn't work, you
should try using a static variable in one file and move all code using
it there. If that doesn't work, you need a global variable, but that
must be uniquely named.
Arnd
next prev parent reply other threads:[~2013-03-27 9:29 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 17:43 Zynq core changes v2 Michal Simek
2013-03-26 17:43 ` [PATCH v2 01/10] arm: zynq: Use standard timer binding Michal Simek
2013-03-26 20:14 ` Steffen Trumtrar
2013-03-27 7:40 ` Michal Simek
2013-03-27 9:04 ` Steffen Trumtrar
2013-03-27 9:25 ` Michal Simek
2013-03-27 9:37 ` Steffen Trumtrar
2013-03-27 9:54 ` Michal Simek
2013-03-26 17:43 ` [PATCH v2 02/10] arm: zynq: Move timer to clocksource interface Michal Simek
2013-03-26 17:43 ` [PATCH v2 03/10] arm: zynq: Move timer to generic location Michal Simek
2013-03-26 17:43 ` [PATCH v2 04/10] arm: zynq: Load scu baseaddress at run time Michal Simek
2013-03-26 21:44 ` Arnd Bergmann
2013-03-27 7:49 ` Michal Simek
2013-03-27 9:29 ` Arnd Bergmann [this message]
2013-03-27 9:37 ` Michal Simek
2013-03-27 10:00 ` Arnd Bergmann
2013-03-27 10:09 ` Michal Simek
2013-03-27 10:43 ` Steffen Trumtrar
2013-03-27 10:49 ` Michal Simek
2013-03-27 10:45 ` Arnd Bergmann
2013-03-27 10:47 ` Michal Simek
2013-03-26 17:43 ` [PATCH v2 05/10] arm: zynq: Move slcr initialization to separate file Michal Simek
2013-03-26 21:43 ` Arnd Bergmann
2013-03-27 6:55 ` Steffen Trumtrar
2013-03-27 9:31 ` Arnd Bergmann
2013-03-27 9:41 ` Steffen Trumtrar
2013-03-27 14:15 ` Michal Simek
2013-03-27 13:01 ` Philip Balister
2013-03-27 13:31 ` Michal Simek
2013-03-26 17:43 ` [PATCH v2 06/10] arm: zynq: Add support for system reset Michal Simek
2013-03-26 17:43 ` [PATCH v2 07/10] arm: zynq: Add support for pmu Michal Simek
2013-03-26 17:43 ` [PATCH v2 08/10] arm: zynq: Add smp support Michal Simek
2013-03-27 8:59 ` Michal Simek
2013-03-26 17:43 ` [PATCH v2 09/10] arm: zynq: Add hotplug support Michal Simek
2013-03-26 17:43 ` [PATCH v2 10/10] arm: zynq: Add cpuidle support Michal Simek
2013-03-26 21:46 ` Arnd Bergmann
2013-03-27 7:56 ` Michal Simek
2013-03-27 9:27 ` Arnd Bergmann
2013-03-27 10:15 ` Daniel Lezcano
2013-03-27 10:07 ` Daniel Lezcano
2013-03-27 10:31 ` Michal Simek
2013-03-27 10:37 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303270929.45733.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox