Subject: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

From: [email-masked] (Arnd Bergmann)
Date: Thu, 28 Mar 2013 15:25:42 +0000

On Thursday 28 March 2013, Russell King - ARM Linux wrote:
> Better:
> 
> #ifdef CONFIG_OF
>         if (!machine_desc->init_irq)
>                 irqchip_init();
>         else
> #endif
>                 machine_desc->init_irq();
> 
> which means we don't even get the test if !OF, and if someone mistakenly
> sets this to NULL for a !OF platform, they get to know about it.

Right. With the new IS_DEFINED() macro, we could even turn this into

	if (IS_DEFINED(CONFIG_OF) && !machine_desc->init_irq)
		irqchip_init();
	else
		machine_desc->init_irq();

to the same effect.

	Arnd