From: tony@atomide•com (Tony Lindgren)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC v2] dmaengine: omap-dma: Start DMA without delay for cyclic channels
Date: Mon, 8 Apr 2013 10:15:19 -0700 [thread overview]
Message-ID: <20130408171519.GP10155@atomide.com> (raw)
In-Reply-To: <20130408170956.GX30923@n2100.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm•linux.org.uk> [130408 10:15]:
> On Mon, Apr 08, 2013 at 09:11:04AM +0200, Peter Ujfalusi wrote:
> > Russell,
> >
> > On 04/03/2013 01:17 PM, Peter Ujfalusi wrote:
> > > cyclic DMA is only used by audio which needs DMA to be started without a
> > > delay.
> > > If the DMA for audio is started using the tasklet we experience random
> > > channel switch (to be more precise: channel shift).
> > >
> > > Reported-by: Peter Meerwald <pmeerw@pmeerw•net>
> > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti•com>
> > > ---
> > > Hi Russell,
> > >
> > > Instead of removing the tasklet we can identify the DMA channel used by audio
> > > based on the cyclic flag of the channel.
> > > I think this can be used as a short term solution to fix the audio channel shift
> > > issue and later when we have the dynamic DMA channel allocation we can adjust
> > > the code.
> >
> > Could you, please look at this patch?
>
> Now that I'm back from a short 4 day break, then yes, and the answer is
> that it's fine. Who's handling the patch?
I suggest Peter resend the patch with also Grant + Linus W cc:d so
they can queue it unless there are other related patches pending
somewhere else.
Regards,
Tony
next prev parent reply other threads:[~2013-04-08 17:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 11:17 [RFC v2] dmaengine: omap-dma: Start DMA without delay for cyclic channels Peter Ujfalusi
2013-04-03 11:24 ` Santosh Shilimkar
2013-04-03 11:52 ` Peter Ujfalusi
2013-04-03 12:00 ` Santosh Shilimkar
2013-04-08 7:11 ` Peter Ujfalusi
2013-04-08 17:09 ` Russell King - ARM Linux
2013-04-08 17:15 ` Tony Lindgren [this message]
2013-04-09 6:52 ` Santosh Shilimkar
2013-04-09 7:19 ` Peter Ujfalusi
2013-04-09 7:26 ` Vinod Koul
2013-04-09 10:20 ` Peter Ujfalusi
2013-04-09 7:19 ` Peter Ujfalusi
2013-04-09 7:21 ` Peter Ujfalusi
2013-04-09 13:54 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130408171519.GP10155@atomide.com \
--to=tony@atomide$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox