From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 05/18] cpuidle: make a single register function for all
Date: Wed, 10 Apr 2013 20:18:17 +0200 [thread overview]
Message-ID: <20130410181817.GM13524@lunn.ch> (raw)
In-Reply-To: <5165A9A6.70905@linaro.org>
On Wed, Apr 10, 2013 at 08:04:22PM +0200, Daniel Lezcano wrote:
> On 04/10/2013 06:55 PM, Andrew Lunn wrote:
> >> +/**
> >> + * cpuidle_register: registers the driver and the cpu devices with the
> >> + * coupled_cpus passed as parameter. This function is used for all common
> >> + * initialization pattern there are in the arch specific drivers. The
> >> + * devices is globally defined in this file.
> >> + *
> >> + * @drv : a valid pointer to a struct cpuidle_driver
> >> + * @coupled_cpus: a cpumask for the coupled states
> >> + *
> >> + * Returns 0 on success, < 0 otherwise
> >> + */
> >> +int cpuidle_register(struct cpuidle_driver *drv,
> >> + const struct cpumask *const coupled_cpus)
> >> +{
> >> + int ret, cpu;
> >> + struct cpuidle_device *device;
> >> +
> >> + ret = cpuidle_register_driver(drv);
> >> + if (ret) {
> >> + printk(KERN_ERR "failed to register cpuidle driver\n");
> >
> > pr_err()
>
> Ok.
>
> >> + return ret;
> >> + }
> >> +
> >> + for_each_possible_cpu(cpu) {
> >> + device = &per_cpu(cpuidle_dev, cpu);
> >> + device->cpu = cpu;
> >> +#ifdef CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED
> >> + device->coupled_cpus = *coupled_cpus;
> >> +#endif
> >> + ret = cpuidle_register_device(device);
> >> + if (!ret)
> >> + continue;
> >> +
> >> + printk(KERN_ERR "Failed to register cpuidle "
> >> + "device for cpu%d\n", cpu);
> >
> > pr_err() and don't split the message over two lines, it makes it
> > harder for somebody to find with
> >
> > grep -r "Failed to register cpuidle device for cpu" *
>
> Ok if the line length is under 80 chars.
Take a closer look at the CodingStyle documents. This is one except to
the rule. Such lines can be longer than 80 characters.
Andrew
next prev parent reply other threads:[~2013-04-10 18:18 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 14:22 [PATCH 00/18] cpuidle: code consolidation Daniel Lezcano
2013-04-10 14:22 ` [PATCH 01/18] ARM: OMAP3: remove cpuidle_wrap_enter Daniel Lezcano
2013-04-10 14:22 ` [PATCH 02/18] cpuidle: remove en_core_tk_irqen flag Daniel Lezcano
2013-04-10 14:22 ` [PATCH 03/18] ARM: ux500: cpuidle: replace for_each_online_cpu by for_each_possible_cpu Daniel Lezcano
2013-04-10 14:22 ` [PATCH 04/18] ARM: imx: cpuidle: create separate drivers for imx5/imx6 Daniel Lezcano
2013-04-12 6:05 ` Shawn Guo
2013-04-12 6:58 ` Daniel Lezcano
2013-04-12 7:11 ` Shawn Guo
2013-04-12 7:12 ` Daniel Lezcano
2013-04-10 14:22 ` [PATCH 05/18] cpuidle: make a single register function for all Daniel Lezcano
2013-04-10 14:59 ` Rob Herring
2013-04-10 15:05 ` Daniel Lezcano
2013-04-22 6:57 ` Daniel Lezcano
2013-04-10 16:55 ` Andrew Lunn
2013-04-10 18:04 ` Daniel Lezcano
2013-04-10 18:18 ` Andrew Lunn [this message]
2013-04-10 22:07 ` Daniel Lezcano
2013-04-10 17:04 ` Andrew Lunn
2013-04-10 18:02 ` Daniel Lezcano
2013-04-10 18:23 ` Andrew Lunn
2013-04-10 19:59 ` Daniel Lezcano
2013-04-10 18:22 ` Colin Cross
2013-04-10 19:59 ` Daniel Lezcano
2013-04-10 14:22 ` [PATCH 06/18] ARM: ux500: cpuidle: use init/exit common routine Daniel Lezcano
2013-04-10 14:22 ` [PATCH 07/18] ARM: at91: " Daniel Lezcano
2013-04-10 14:39 ` Nicolas Ferre
2013-04-10 14:22 ` [PATCH 08/18] ARM: OMAP3: " Daniel Lezcano
2013-04-10 14:22 ` [PATCH 09/18] ARM: s3c64xx: " Daniel Lezcano
2013-04-10 14:22 ` [PATCH 10/18] ARM: tegra1: " Daniel Lezcano
2013-04-10 17:29 ` Stephen Warren
2013-04-10 18:05 ` Daniel Lezcano
2013-04-10 14:22 ` [PATCH 11/18] ARM: shmobile: " Daniel Lezcano
2013-04-11 2:46 ` Simon Horman
2013-04-10 14:22 ` [PATCH 12/18] ARM: OMAP4: " Daniel Lezcano
2013-04-10 14:22 ` [PATCH 13/18] ARM: tegra2: " Daniel Lezcano
2013-04-11 1:01 ` Joseph Lo
2013-04-11 5:58 ` Daniel Lezcano
2013-04-10 14:22 ` [PATCH 14/18] ARM: tegra3: " Daniel Lezcano
2013-04-10 14:22 ` [PATCH 15/18] ARM: calxeda: " Daniel Lezcano
2013-04-10 14:31 ` Rob Herring
2013-04-10 14:22 ` [PATCH 16/18] ARM: kirkwood: " Daniel Lezcano
2013-04-10 14:22 ` [PATCH 17/18] ARM: davinci: " Daniel Lezcano
2013-04-10 14:22 ` [PATCH 18/18] ARM: imx: " Daniel Lezcano
2013-04-10 19:12 ` [PATCH 00/18] cpuidle: code consolidation Rafael J. Wysocki
2013-04-10 20:01 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410181817.GM13524@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox