From: andrew.murray@arm•com (Andrew Murray)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v7 2/3] of/pci: Provide support for parsing PCI DT ranges property
Date: Thu, 18 Apr 2013 16:38:03 +0100 [thread overview]
Message-ID: <20130418153803.GA19373@arm.com> (raw)
In-Reply-To: <CACxGe6u7yoecyTR2r-EzpcRxLuSw-p9KC7jA12wEQZs4of3vFA@mail.gmail.com>
On Thu, Apr 18, 2013 at 04:29:54PM +0100, Grant Likely wrote:
> On Thu, Apr 18, 2013 at 3:24 PM, Andrew Murray <andrew.murray@arm•com> wrote:
> > On Thu, Apr 18, 2013 at 02:44:01PM +0100, Grant Likely wrote:
> >> On Tue, 16 Apr 2013 11:18:27 +0100, Andrew Murray <Andrew.Murray@arm•com> wrote:
> >> > /* Act based on address space type */
> >> > res = NULL;
> >> > - switch ((pci_space >> 24) & 0x3) {
> >> > - case 1: /* PCI IO space */
> >> > + res_type = range.flags & IORESOURCE_TYPE_BITS;
> >> > + if (res_type == IORESOURCE_IO) {
> >>
> >> Why the change from switch() to an if/else if sequence?
> >
> > Russell King suggested this change - see
> > https://patchwork.kernel.org/patch/2323941/
>
> Umm, that isn't what that link shows. That link shows the patch
> already changing to an if/else if construct, and rmk is commenting on
> that.
Arh yes sorry about that. I can't find or remember any good reason why I
changed it from a switch to an if/else :\
Andrew Murray
next prev parent reply other threads:[~2013-04-18 15:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 10:18 [PATCH v7 0/3] of/pci: Provide common support for PCI DT parsing Andrew Murray
2013-04-16 10:18 ` [PATCH v7 1/3] of/pci: Unify pci_process_bridge_OF_ranges from Microblaze and PowerPC Andrew Murray
2013-04-16 10:30 ` Andrew Murray
2013-04-17 16:00 ` Grant Likely
2013-04-17 16:10 ` Jason Cooper
2013-04-17 16:17 ` Grant Likely
2013-04-17 16:22 ` Jason Cooper
2013-04-18 12:48 ` Grant Likely
2013-04-18 13:06 ` Jason Cooper
2013-04-16 10:18 ` [PATCH v7 2/3] of/pci: Provide support for parsing PCI DT ranges property Andrew Murray
2013-04-18 13:44 ` Grant Likely
2013-04-18 14:24 ` Andrew Murray
2013-04-18 15:29 ` Grant Likely
2013-04-18 15:38 ` Andrew Murray [this message]
2013-04-22 10:57 ` Andrew Murray
2013-04-16 10:18 ` [PATCH v7 3/3] of/pci: mips: convert to common of_pci_range_parser Andrew Murray
2013-04-17 15:42 ` Linus Walleij
2013-04-18 12:59 ` Andrew Murray
2013-04-18 13:09 ` Jason Cooper
2013-04-19 7:19 ` Gabor Juhos
2013-04-20 22:33 ` Jason Cooper
2013-04-21 7:27 ` Gabor Juhos
2013-04-22 10:49 ` Andrew Murray
2013-04-18 13:45 ` Grant Likely
2013-04-18 14:26 ` Andrew Murray
2013-04-16 15:05 ` [PATCH v7 0/3] of/pci: Provide common support for PCI DT parsing Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130418153803.GA19373@arm.com \
--to=andrew.murray@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox