Subject: [PATCH 21/32] dmaengine: ste_dma40: Also report the number of logical channels

From: [email-masked] (Vinod Koul)
Date: Mon, 22 Apr 2013 15:18:42 +0530

On Mon, Apr 22, 2013 at 11:14:55AM +0100, Lee Jones wrote:
> On Mon, 22 Apr 2013, Vinod Koul wrote:
> 
> > On Thu, Apr 18, 2013 at 11:12:03AM +0100, Lee Jones wrote:
> > > Now we know the total of physical and logical channels, we may as
> > > well report them within the information log.
> > > 
> > > Before:
> > > dma40 dma40.0: hardware revision: 3 @ 0x801c0000 with 8 physical channels
> > > 
> > > After:
> > > <as above ...> and 256 logical channels
> > > 
> > > Cc: Vinod Koul <[email-masked]>
> > > Cc: Dan Williams <[email-masked]>
> > > Cc: Per Forlin <[email-masked]>
> > > Cc: Rabin Vincent <[email-masked]>
> > > Signed-off-by: Lee Jones <[email-masked]>
> > > ---
> > >  drivers/dma/ste_dma40.c |    5 +++--
> > >  1 file changed, 3 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
> > > index 282dd59..805049c 100644
> > > --- a/drivers/dma/ste_dma40.c
> > > +++ b/drivers/dma/ste_dma40.c
> > > @@ -3200,8 +3200,9 @@ static struct d40_base * __init d40_hw_detect_init(struct platform_device *pdev)
> > >  
> > >  	num_log_chans = num_phy_chans * D40_MAX_LOG_CHAN_PER_PHY;
> > >  
> > > -	dev_info(&pdev->dev, "hardware revision: %d @ 0x%x with %d physical channels\n",
> > > -		 rev, res->start, num_phy_chans);
> > > +	dev_info(&pdev->dev, "hardware revision: %d @ 0x%x with "
> > > +		"%d physical channels and %d logical channels\n",
> > > +		rev, res->start, num_phy_chans, num_log_chans);
> > Splitting log messages across lines is bad idea and sacrifces readablity... also
> > wasnt splitting logging to multiple lines emit checkpatch warn
> 
> You also get a check-patch error if your lines are over 80 chars.
No, you get a warn
> 
> How would you solve this?
Use common sense :) I would never sacrfice readablity of code. Erring on 80chars
is fine by me as long as it makes sense.

--
~Vinod