From: tony@atomide•com (Tony Lindgren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: OMAP3: Beagle: Fix USB Host on beagle xM Ax/Bx
Date: Wed, 8 May 2013 15:12:22 -0700 [thread overview]
Message-ID: <20130508221221.GJ32546@atomide.com> (raw)
In-Reply-To: <1366024808-4691-1-git-send-email-rogerq@ti.com>
* Roger Quadros <rogerq@ti•com> [130415 04:25]:
> On Beagle xM Rev. Ax/Bx, the USB power enable GPIO logic is
> reversed when compared to other revisions i.e. it is
> active high instead of active low.
>
> Use the beagle_config.usb_pwr_level flag correctly so that
> the power regulator can be configured at runtime.
>
> Signed-off-by: Roger Quadros <rogerq@ti•com>
Thanks applying into omap-for-v3.10/fixes.
Regards,
Tony
> ---
> arch/arm/mach-omap2/board-omap3beagle.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index 5382215..21136b2 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -112,13 +112,13 @@ static u8 omap3_beagle_version;
> */
> static struct {
> int mmc1_gpio_wp;
> - int usb_pwr_level;
> + bool usb_pwr_level; /* 0 - Active Low, 1 - Active High */
> int dvi_pd_gpio;
> int usr_button_gpio;
> int mmc_caps;
> } beagle_config = {
> .mmc1_gpio_wp = -EINVAL,
> - .usb_pwr_level = GPIOF_OUT_INIT_LOW,
> + .usb_pwr_level = 0,
> .dvi_pd_gpio = -EINVAL,
> .usr_button_gpio = 4,
> .mmc_caps = MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA,
> @@ -178,7 +178,7 @@ static void __init omap3_beagle_init_rev(void)
> case 0:
> printk(KERN_INFO "OMAP3 Beagle Rev: xM Ax/Bx\n");
> omap3_beagle_version = OMAP3BEAGLE_BOARD_XM;
> - beagle_config.usb_pwr_level = GPIOF_OUT_INIT_HIGH;
> + beagle_config.usb_pwr_level = 1;
> beagle_config.mmc_caps &= ~MMC_CAP_8_BIT_DATA;
> break;
> case 2:
> --
> 1.7.4.1
>
next prev parent reply other threads:[~2013-05-08 22:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 11:20 [PATCH] ARM: OMAP3: Beagle: Fix USB Host on beagle xM Ax/Bx Roger Quadros
2013-05-08 22:12 ` Tony Lindgren [this message]
2013-07-09 13:02 ` Stefan Roese
2013-07-09 13:55 ` Roger Quadros
[not found] ` <51DC1B47.7070504@denx.de>
2013-07-09 17:20 ` Roger Quadros
2013-07-11 10:24 ` Roger Quadros
2013-07-11 10:45 ` Stefan Roese
2013-07-11 12:00 ` Roger Quadros
2013-07-11 12:33 ` Stefan Roese
2013-07-11 12:41 ` Stefan Roese
2013-07-11 14:35 ` Roger Quadros
2013-07-11 15:34 ` Stefan Roese
[not found] ` <51DEF0DE.4050607@denx.de>
2013-07-12 9:15 ` Roger Quadros
2013-07-12 10:52 ` Stefan Roese
2013-07-15 8:16 ` Roger Quadros
2013-07-15 8:24 ` Stefan Roese
2013-07-16 14:37 ` Roger Quadros
2013-07-16 16:19 ` Stefan Roese
2013-07-19 13:04 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130508221221.GJ32546@atomide.com \
--to=tony@atomide$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox