From: tony@atomide•com (Tony Lindgren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv2] ARM:dts:omap4-panda:Update the LED support for the panda DTS
Date: Wed, 8 May 2013 16:47:46 -0700 [thread overview]
Message-ID: <20130508234745.GV32546@atomide.com> (raw)
In-Reply-To: <51703BEF.6050804@ti.com>
* Dan Murphy <dmurphy@ti•com> [130418 11:35]:
> On 04/18/2013 04:30 AM, Vincent Stehl? wrote:
> >On 04/17/2013 10:16 PM, Dan Murphy wrote:
> >>The GPIO for LED D1 on the omap4-panda a1-a3 rev and the omap4-panda-es
> >>are different.
> >(..)
> >>diff --git a/arch/arm/boot/dts/omap4-panda-common.dtsi b/arch/arm/boot/dts/omap4-panda-common.dtsi
> >>index 03bd60d..0c48f6b 100644
> >>--- a/arch/arm/boot/dts/omap4-panda-common.dtsi
> >>+++ b/arch/arm/boot/dts/omap4-panda-common.dtsi
> >(..)
> >>@@ -135,6 +136,25 @@
> >> 0xf0 0x118 /* i2c4_sda PULLUP | INPUTENABLE | MODE0 */
> >> >;
> >> };
> >>+
> >>+ led_gpio_pins: pinmux_leds_pins {
> >>+ pinctrl-single,pins = <
> >>+ >;
> >>+ };
> >>+};
> >Hi,
> >
> >FYI, there was a recent discussion precisely on this topic, where Tomy
> >suggested to remove the empty section:
> >http://marc.info/?l=linux-omap&m=136546635409232&w=2
> >
> >Apart from that, I just tested your patch on top of Tomy's
> >omap-for-v3.10/dt branch and it is working fine for me on PandaBoards
> >EA3, A4 and ES.
> >
> >Tested-by: Vincent Stehl? <v-stehle@ti•com>
> >
> >Best regards,
> >
> >V.
> >
> Thanks for testing Vincent
>
> Is there a way to append the data to an already existing node?
> I do not see a clean way.
If you have something in omap4-panda-common.dtsi and the same entry
in the omap4-panda-es.dts, the entries in omap4-panda-es.dts will
override and append the entries in omap4-panda-common.dtsi.
So I think you can avoid the empty entry that way.
Regards,
Tony
next prev parent reply other threads:[~2013-05-08 23:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 20:16 [PATCHv2] ARM:dts:omap4-panda:Update the LED support for the panda DTS Dan Murphy
2013-04-18 9:30 ` Vincent Stehlé
2013-04-18 18:31 ` Dan Murphy
2013-05-08 23:47 ` Tony Lindgren [this message]
2013-05-09 18:08 ` Dan Murphy
2013-05-09 18:45 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130508234745.GV32546@atomide.com \
--to=tony@atomide$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox