From: heiko@sntech•de (Heiko Stübner)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs
Date: Wed, 15 May 2013 23:48:31 +0200 [thread overview]
Message-ID: <201305152348.32171.heiko@sntech.de> (raw)
In-Reply-To: <5193FC08.5040002@gmail.com>
Am Mittwoch, 15. Mai 2013, 23:20:08 schrieb Sylwester Nawrocki:
> On 05/15/2013 10:31 PM, Heiko St?bner wrote:
> >>> + BUG();
> >>>
> >> > Isn't that a bit nasty. This macro should be used with care and we
> >> > should recover if possible. dev_err()?
> >
> > runtime_config already denies any settings not in the 1,2 or 4bytes range
> > - the default-part should therefore never be reached. So if any other
> > value magically appears in the register and triggers the default-part,
> > something is seriously wrong. So my guess is, the BUG might be
> > appropriate.
> >
> > On the other hand the whole default+BUG part could also simply go away,
> > for the same reasons.
>
> IMHO BUG() is not needed at all. As Linus suggested dev_err() is such case
> or WARN_ON() would be more appropriate. This has been discussed in the past
> extensively, not sure if you are aware of the other Linus' opinion on
> BUG()/BUG_ON() proliferation: https://lkml.org/lkml/2012/9/27/461
Very interesting read and I'll keep this in mind in the future. What about the
other option ... i.e. simply getting rid of the whole "error handling", as the
other code paths should already make sure that only valid values get written
into the register.
Can the value change in the register somehow on its own without kernel
intervention, or does this not happen?
Thanks
Heiko
next prev parent reply other threads:[~2013-05-15 21:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 11:30 [RFC 0/4] ARM: S3C24XX: add dmaengine based dma-driver Heiko Stübner
[not found] ` <201305111331.25405.heiko@sntech.de>
2013-05-14 12:47 ` [RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs Linus Walleij
2013-05-14 13:51 ` Heiko Stübner
2013-05-15 18:38 ` Linus Walleij
2013-05-14 14:21 ` Tomasz Figa
2013-05-15 18:53 ` Linus Walleij
2013-05-15 20:31 ` Heiko Stübner
2013-05-15 21:20 ` Sylwester Nawrocki
2013-05-15 21:48 ` Heiko Stübner [this message]
2013-05-15 22:02 ` Tomasz Figa
2013-05-15 22:45 ` Heiko Stübner
2013-05-15 23:26 ` Tomasz Figa
2013-05-17 12:20 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305152348.32171.heiko@sntech.de \
--to=heiko@sntech$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox