From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] regulator: ab8500-ext: Don't register without initialisation data
Date: Wed, 22 May 2013 16:08:10 +0200 [thread overview]
Message-ID: <201305221608.10759.arnd@arndb.de> (raw)
In-Reply-To: <CACRpkdYHiwbGonH80aJfHxP6F+hLb+_KdCr_g5ae1Yr-v=WcxA@mail.gmail.com>
On Wednesday 22 May 2013, Linus Walleij wrote:
> > diff --git a/drivers/regulator/ab8500-ext.c b/drivers/regulator/ab8500-ext.c
> > index b4d4547..8421537 100644
> > --- a/drivers/regulator/ab8500-ext.c
> > +++ b/drivers/regulator/ab8500-ext.c
> > @@ -334,6 +334,12 @@ int ab8500_ext_regulator_init(struct platform_device *pdev)
> > return -EINVAL;
> > }
> >
> > + /* have any external regulators been specified? */
> > + if (pdata->num_ext_regulator == 0) {
> > + dev_warn(&pdev->dev, "Not using external regulators\n");
> > + return 0;
> > + }
>
> dev_warn() is really when we warn about something really nasty, worse
> than dev_err(). It seems dev_info() is more apropriate.
Are you confusing it with dev_crit()?
This is how the levels are defined, and "warning" is less urgent than "error":
#define KERN_EMERG KERN_SOH "0" /* system is unusable */
#define KERN_ALERT KERN_SOH "1" /* action must be taken immediately */
#define KERN_CRIT KERN_SOH "2" /* critical conditions */
#define KERN_ERR KERN_SOH "3" /* error conditions */
#define KERN_WARNING KERN_SOH "4" /* warning conditions */
#define KERN_NOTICE KERN_SOH "5" /* normal but significant condition */
#define KERN_INFO KERN_SOH "6" /* informational */
#define KERN_DEBUG KERN_SOH "7" /* debug-level messages */
Arnd
next prev parent reply other threads:[~2013-05-22 14:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 12:47 [RC FIXES] Fix broken MMC devices on Snowball Lee Jones
2013-05-22 12:47 ` [PATCH] ARM: ux500: Allow Snowball to pass its own regulator settings Lee Jones
2013-05-24 11:25 ` Lee Jones
2013-05-22 12:47 ` [PATCH] regulator: ab8500-ext: Don't register without initialisation data Lee Jones
2013-05-22 13:18 ` Linus Walleij
2013-05-22 14:08 ` Arnd Bergmann [this message]
2013-05-23 8:23 ` Linus Walleij
2013-05-22 15:53 ` Mark Brown
2013-05-22 16:53 ` Lee Jones
2013-05-22 17:45 ` Mark Brown
2013-05-23 7:09 ` Lee Jones
2013-05-23 14:24 ` Mark Brown
2013-05-23 14:44 ` Lee Jones
2013-05-23 15:18 ` Mark Brown
2013-05-23 15:30 ` Lee Jones
2013-05-24 11:23 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305221608.10759.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox